You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/21 01:34:08 UTC
[GitHub] [tvm] moderato opened a new pull request #9058: [AutoTVM] Sort arguments of built autotvm func in topological order.
moderato opened a new pull request #9058:
URL: https://github.com/apache/tvm/pull/9058
Currently, the order of the AutoTVM function arguments might cause confusion in some cases. For example, for a 3x3 conv, the order of `arg_bufs` after calling `s, arg_bufs = task.instantiate(best_config)` is output, filter, input, while for a 1x1 conv, the order is output, input, filter, since it doesn't need padding and thus both input and filter are directly the input_tensors of conv, in which input comes first. This will significantly affect the use of the generated CUDA/asm code externally.
This fix sort the arguments in topological order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #9058: [AutoTVM] Sort arguments of built autotvm func in topological order.
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9058:
URL: https://github.com/apache/tvm/pull/9058#issuecomment-1008444653
@moderato Please update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9058: [AutoTVM] Sort arguments of built autotvm func in topological order.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9058:
URL: https://github.com/apache/tvm/pull/9058#issuecomment-924496531
cc @mbs-octoml @jroesch we need to address this by providing an explicit pass to thread the argument order through lowering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #9058: [AutoTVM] Sort arguments of built autotvm func in topological order.
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #9058:
URL: https://github.com/apache/tvm/pull/9058#issuecomment-924160790
The change looks good to me, but I'm not sure if it will affect existing cases. Please try to fix the CI and let's see.
Also cc @merrymercy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org