You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 06:02:41 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #10839: [WIP] Eslint dependencies versions updates
kgabryje opened a new pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839
### SUMMARY
Upgrade eslint packages: eslint, eslint-config-airbnb, eslint-import-resolver-webpack, eslint-plugin-cypress and their dependencies.
This is the first pull request of the series - as upgrading eslint-config-airbnb caused a lot of new errors, I disabled the offending rules and I will re-enable them in subsequent PRs with proper fixes.
### TEST PLAN
Run eslint on source files, verify that there are no new Javascript/Typescript errors.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691635123
@etr2460 I will add comments to the rules that will soon be re-enabled (I have a series of PRs incoming as soon as we merge this one 🙂). However, some of the rules require some discussion about whether we want to re-enable them or not. I'll mark them appropriately.
@rusackas That error from ESLint seems legit as we do import `zlib` and `path` in webpack config files explicitly. If we don't want them to be listed in package.json deps, then maybe we should just disable the `no-extraneous-dependencies` rule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.63% -0.71%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14588 -177
- Misses 9303 9469 +166
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.63% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.46% <0.00%> (-0.29%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...f1eede2](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691296374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691296374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487651881
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
Please use `[overrides](https://eslint.org/docs/user-guide/configuring#disabling-rules-only-for-a-group-of-files)` to add `webpack` specific configs. E.g.:
```
overrides: [
{
files: 'webpack*.js',
env: 'node',
rules: {
'import/no-extraneous-dependencies': 0,
},
},
],
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487270741
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-690962205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487497607
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
Yea, it wasn't necessary. Fixed 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `1.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.29% -1.05%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14506 -259
- Misses 9303 9551 +248
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.29% <ø> (-1.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...f1eede2](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `0.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.62% -0.73%
==========================================
Files 380 380
Lines 24068 24068
==========================================
- Hits 14765 14591 -174
- Misses 9303 9477 +174
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.62% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.48% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...b8e4011](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487651881
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
Please use `overrides` to add `webpack` specific configs. E.g.:
```
overrides: [
{
files: 'webpack*.js',
env: 'node',
rules: {
'import/no-extraneous-dependencies': 0,
},
},
],
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487689954
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
Awesome! Thanks for jumping in @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-690962205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487651881
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
Please use [`overrides`](https://eslint.org/docs/user-guide/configuring#disabling-rules-only-for-a-group-of-files) to add `webpack` specific configs. E.g.:
```
overrides: [
{
files: 'webpack*.js',
env: 'node',
rules: {
'import/no-extraneous-dependencies': 0,
},
},
],
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487497883
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
It is used in `webpack.proxy-config.js` and it triggers `import/no-extraneous-dependencies` rule if it's not listed in deps
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.69% -0.66%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14601 -164
- Misses 9303 9456 +153
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.69% <ø> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.50% <0.00%> (-0.84%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.60% <0.00%> (-0.16%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.30% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...f1eede2](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.67% -0.67%
==========================================
Files 380 380
Lines 24068 24068
==========================================
- Hits 14765 14604 -161
- Misses 9303 9464 +161
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.67% <ø> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.50% <0.00%> (-0.84%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...b8e4011](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487270741
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487645454
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
Same thing here, wondering if it makes sense to move this to `devDependencies` and/or add a `// eslint-disable-next-line import/no-extraneous-dependencies` comment to quiet it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487497739
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
It was replaced in version 6 of eslint-plugin-jsx-a11y by `anchor-is-valid` (https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/a14617528cda23c6c88902ace1d083e4e13ac271)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691633329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=h1) Report
> Merging [#10839](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `1.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
==========================================
- Coverage 61.34% 60.29% -1.05%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14506 -259
- Misses 9303 9551 +248
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.29% <ø> (-1.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/10839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=footer). Last update [686c19a...b8e4011](https://codecov.io/gh/apache/incubator-superset/pull/10839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487497824
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
It is used in `webpack.config.js` and it triggers `import/no-extraneous-dependencies` rule if it's not listed in deps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-690962205
Hey @rusackas, can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487644674
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
@kgabryje Since most production servers probably use a static build rather than the webpack server, I wonder if it makes sense to move these to devDependencies. Does that still cause an eslint error?
If it does still cause an error, I'd be tempted to leave it as a devDependency anyway and/or use a `// eslint-disable-next-line import/no-extraneous-dependencies` comment in `webpack.config.js` to quiet it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487270741
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -17,7 +17,12 @@
* under the License.
*/
module.exports = {
- extends: ['airbnb', 'prettier'],
+ extends: [
+ 'airbnb',
+ 'prettier',
+ 'prettier/@typescript-eslint',
Review comment:
why does the default need to extend prettier/@typescript? shouldn't this only be needed for `.ts` and `.tsx` files?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -72,19 +78,26 @@ module.exports = {
],
'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0,
+ 'import/no-useless-path-segments': 0,
'import/prefer-default-export': 0,
indent: 0,
'jsx-a11y/anchor-has-content': 0,
- 'jsx-a11y/href-no-hash': 0,
Review comment:
did this rule get removed from the airbnb defaults? or was it renamed to `anchor-is-valid`?
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
why do we need to add this to the deps? I don't see it used anywhere?
##########
File path: superset-frontend/src/explore/components/controls/SelectAsyncControl.jsx
##########
@@ -76,7 +76,7 @@ const SelectAsyncControl = props => {
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
- this.props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
+ props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
Review comment:
ooo, nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487644674
##########
File path: superset-frontend/package.json
##########
@@ -121,6 +121,7 @@
"mousetrap": "^1.6.1",
"mustache": "^2.2.1",
"omnibar": "^2.1.1",
+ "path": "^0.12.7",
Review comment:
@kgabryje Since most production servers probably use a static build rather than the webpack server, I wonder if it makes sense to move these to devDependencies. Does that still cause an eslint error?
If it does still cause an error, I'd be tempted to leave it as a devDependency anyway and/or use the ol' `// eslint-disable-next-line import/no-extraneous-dependencies` to quiet it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#issuecomment-691296374
Also, maybe you could add comments next to the rules you disabled for this PR, that way we know which ones we want to reenable sooner rather than later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `pacakge-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the `package-lock.json` file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487274180
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
These path and zlib dependencies keep cropping up for people, and eslint throws an error about them not being in the dependencies. I'm not sure the root cause... resetting the pacakge.json file to what's on master often resolves it, but the issue keeps cropping up like a weed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #10839: Eslint dependencies versions updates
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #10839:
URL: https://github.com/apache/incubator-superset/pull/10839#discussion_r487676403
##########
File path: superset-frontend/package.json
##########
@@ -168,7 +169,8 @@
"rison": "^0.1.1",
"shortid": "^2.2.6",
"urijs": "^1.18.10",
- "use-query-params": "^0.4.5"
+ "use-query-params": "^0.4.5",
+ "zlib": "^1.0.5"
Review comment:
I followed @ktmud's suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org