You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/13 22:17:18 UTC

[GitHub] TisonKun opened a new pull request #7303: [FLINK-10569] [tests] Get rid of Scheduler and Instance from valid tests

TisonKun opened a new pull request #7303: [FLINK-10569] [tests] Get rid of Scheduler and Instance from valid tests
URL: https://github.com/apache/flink/pull/7303
 
 
   ## What is the purpose of the change
   
   Legacy class `Scheduler` and `Instance` are still used in some valid tests like `ExecutionGraphRestartTest`. We should replace them with FLIP-6 schedule mode. The best way I can find is use `TestingSlotProvider` or `ProgrammedSlotProvider`.
   
   **This is now part of FLINK-10569 and I'm going to port tests commit by commit. They are a bit orthogonal so I'm also glad to see we get things done in several pull requests.**
   
   ## Brief change log
   
   - port `PointwisePatternTest`, `Scheduler` -> `TestingSlotProvider`
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any more test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
     - The serializers: (**no**)
     - The runtime per-record code paths (performance sensitive): (**no**)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
     - The S3 file system connector: (**no**)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**no**)
     - If yes, how is the feature documented? (**not applicable**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services