[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #5168: [DISCUSS] Simplify the configuration API of ShardingKeyGenerator on spring namespace

[GitBox <gi...@apache.org>]

cherrylzhao edited a comment on issue #5168: [DISCUSS]  Simplify the configuration  API of ShardingKeyGenerator on spring namespace
URL: https://github.com/apache/incubator-shardingsphere/issues/5168#issuecomment-613190795
 
 
   in fact, `<sharding:key-generator id="orderKeyGenerator" column="order_id" type="INCREMENT" />` is the old api before #1997, in this way keyGenerator was instanced by ServiceLoader which could not been managed by spring-container. TaoZhiMLND and I have made many work in order to keep the old api but it is not possible to create 2 different beans in one spring tag, so we separate the KeyGeneratorAlgorithm from the <sharding:key-generator> using FactoryBean to wrap the serviceLoader as a spring bean

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services