You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/07 13:01:39 UTC
[GitHub] [spark] yikf opened a new pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
yikf opened a new pull request #31510:
URL: https://github.com/apache/spark/pull/31510
### What changes were proposed in this pull request?
Currently, we pass the default value `EmptyRow` to method `checkEvaluation` in the StringExpressionsSuite, but the default value of the 'checkEvaluation' method parameter is the `emptyRow`.
We can clean the parameter for Code Simplifications.
### Why are the changes needed?
for Code Simplifications
**before**:
```
def testConcat(inputs: String*): Unit = {
val expected = if (inputs.contains(null)) null else inputs.mkString
checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected, EmptyRow)
}
```
**after**:
```
def testConcat(inputs: String*): Unit = {
val expected = if (inputs.contains(null)) null else inputs.mkString
checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected)
}
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or Github action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775525435
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39631/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775250637
gentle ping @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775629976
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31510:
URL: https://github.com/apache/spark/pull/31510#discussion_r571615032
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
##########
@@ -28,7 +28,7 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("concat") {
def testConcat(inputs: String*): Unit = {
val expected = if (inputs.contains(null)) null else inputs.mkString
- checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected, EmptyRow)
+ checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected)
Review comment:
For reviewer, method of the `checkEvaluation` as follow:
`protected def checkEvaluation(
expression: => Expression, expected: Any, inputRow: InternalRow = EmptyRow): Unit`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775483346
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774841475
> Same, we can merge it, but you can mark these MINOR and yes if you can find more logically related small changes, you can combine them.
Thanks for your comment, That's all i've found so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775555759
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39631/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775250582
gentle ping @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775611895
**[Test build #135048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135048/testReport)** for PR 31510 at commit [`bff7afd`](https://github.com/apache/spark/commit/bff7afde412ea15378a5c32d878b6c24a810d24e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775509993
**[Test build #135048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135048/testReport)** for PR 31510 at commit [`bff7afd`](https://github.com/apache/spark/commit/bff7afde412ea15378a5c32d878b6c24a810d24e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774673125
> Can one of the admins verify this patch?
Ok to test please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775555759
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39631/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775536471
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39631/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774824449
Same, we can merge it, but you can mark these MINOR and yes if you can find more logically related small changes, you can combine them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775258108
> @yikf because this is trivial, I don't think there's a hurry to merge. We usually leave things open a day or two. That said I think this is fine, just tiny.
ok，thanks🤗
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775255800
@yikf because this is trivial, I don't think there's a hurry to merge. We usually leave things open a day or two. That said I think this is fine, just tiny.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774672462
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf removed a comment on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf removed a comment on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775250637
gentle ping @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774670867
cc @dongjoon-hyun @HyukjinKwon , thanks for taking a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31510:
URL: https://github.com/apache/spark/pull/31510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31510:
URL: https://github.com/apache/spark/pull/31510#discussion_r571615032
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
##########
@@ -28,7 +28,7 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("concat") {
def testConcat(inputs: String*): Unit = {
val expected = if (inputs.contains(null)) null else inputs.mkString
- checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected, EmptyRow)
+ checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected)
Review comment:
For reviewer, method of the `checkEvaluation` as follow:
` protected def checkEvaluation(
expression: => Expression, expected: Any, inputRow: InternalRow = EmptyRow): Unit = {
// Make it as method to obtain fresh expression everytime.
def expr = prepareEvaluation(expression)
val catalystValue = CatalystTypeConverters.convertToCatalyst(expected)
checkEvaluationWithoutCodegen(expr, catalystValue, inputRow)
checkEvaluationWithMutableProjection(expr, catalystValue, inputRow)
if (GenerateUnsafeProjection.canSupport(expr.dataType)) {
checkEvaluationWithUnsafeProjection(expr, catalystValue, inputRow)
}
checkEvaluationWithOptimization(expr, catalystValue, inputRow)
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774672462
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775629976
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135048/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774802254
> I would encourage to avoid creating a PR to fix only nits, but review other people's PR to catch these nits or fix them when you happen to touch the codes around here.
Thanks for your comment. i see your think, shoud we close the JIRA&PR directly or after merge it?
but, FYI, The role of that PR may not be that simple unless we happen to touch the codes around here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-774795769
I would encourage to avoid creating a PR to fix only nits, but review other people's PR to catch these nits or fix them when you happen to touch the codes around here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775612869
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31510:
URL: https://github.com/apache/spark/pull/31510#discussion_r571615032
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
##########
@@ -28,7 +28,7 @@ class StringExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
test("concat") {
def testConcat(inputs: String*): Unit = {
val expected = if (inputs.contains(null)) null else inputs.mkString
- checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected, EmptyRow)
+ checkEvaluation(Concat(inputs.map(Literal.create(_, StringType))), expected)
Review comment:
For reviewer, Method signature for `checkEvaluation` as follow:
`checkEvaluation(expression: => Expression, expected: Any, inputRow: InternalRow = EmptyRow)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31510: [SPARK-34395][SQL]Clean up unused code for code simplifications.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31510:
URL: https://github.com/apache/spark/pull/31510#issuecomment-775509993
**[Test build #135048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135048/testReport)** for PR 31510 at commit [`bff7afd`](https://github.com/apache/spark/commit/bff7afde412ea15378a5c32d878b6c24a810d24e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org