You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2018/07/24 15:20:47 UTC
BookKeeper code coverage incredibly dropped in June from 72% to 54% !!
Hi,
In June, the 14th, code coverage dropped
here: 72%
https://coveralls.io/builds/17447847
here: 54%
https://coveralls.io/builds/17501203
This commit seems the cause (as reported by Coveralls.io)
https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f7eb80bd64e
Anyone has cycles to take a look ?
Enrico
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Enrico Olivelli <eo...@gmail.com>.
I am playing with this Job
https://builds.apache.org/job/bookkeeper_codecoverage_tmp
Notifications will be sent to my @apache adress
I will be back with news soon
Enrico
Il giorno lun 30 lug 2018 alle ore 21:02 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:
>
>
> Il lun 30 lug 2018, 19:51 Sijie Guo <gu...@gmail.com> ha scritto:
>
>> Great work, Enrico!
>>
>> Can we enable the code coverage for all modules?
>>
>
> In theory we are running the full suite as we are using -Dstream.
> I will double check
>
> Enrico
>
>
>> - Sijie
>>
>> On Mon, Jul 30, 2018 at 7:46 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Code coverage report restored !
>> >
>> > We are back to 72%
>> >
>> > see
>> > https://coveralls.io/github/apache/bookkeeper
>> >
>> > Thank you JV, Sijie and Ivan !!
>> >
>> > Enrico
>> >
>> >
>> >
>> > Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli <
>> > eolivelli@gmail.com> ha scritto:
>> >
>> > > Here it is the patch
>> > >
>> > > Please Sijie take a look.
>> > > I would like to restore Coveralls before releasing 4.8
>> > >
>> > > Thanks
>> > > Enrico
>> > >
>> > > Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
>> > > eolivelli@gmail.com> ha scritto:
>> > >
>> > >>
>> > >>
>> > >> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <
>> jujjuri@gmail.com>
>> > >> ha scritto:
>> > >>
>> > >>> I don't see bookkeeper-server in the
>> > >>> https://coveralls.io/builds/17501203
>> > >>> report. Rest looks almost identical.
>> > >>> That must be causing the overall drop.
>> > >>>
>> > >>
>> > >> Thank you.
>> > >> I have an idea, that change introduced a specific configuration for
>> > >> surefire, the maven plugin which executes tests. Maybe it is
>> disabling
>> > >> JaCoCo agent.
>> > >>
>> > >> I will be back with news and hopefully a patch
>> > >>
>> > >> Enrico
>> > >>
>> > >>
>> > >>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <
>> eolivelli@gmail.com>
>> > >>> wrote:
>> > >>>
>> > >>> > Hi,
>> > >>> > In June, the 14th, code coverage dropped
>> > >>> >
>> > >>> > here: 72%
>> > >>> > https://coveralls.io/builds/17447847
>> > >>> >
>> > >>> > here: 54%
>> > >>> > https://coveralls.io/builds/17501203
>> > >>> >
>> > >>> > This commit seems the cause (as reported by Coveralls.io)
>> > >>> >
>> > >>>
>> >
>> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
>> > >>> > 7eb80bd64e
>> > >>> >
>> > >>> > Anyone has cycles to take a look ?
>> > >>> >
>> > >>> >
>> > >>> > Enrico
>> > >>> >
>> > >>>
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Jvrao
>> > >>> ---
>> > >>> First they ignore you, then they laugh at you, then they fight you,
>> > then
>> > >>> you win. - Mahatma Gandhi
>> > >>>
>> > >> --
>> > >>
>> > >>
>> > >> -- Enrico Olivelli
>> > >>
>> > >
>> >
>>
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Enrico Olivelli <eo...@gmail.com>.
Il lun 30 lug 2018, 19:51 Sijie Guo <gu...@gmail.com> ha scritto:
> Great work, Enrico!
>
> Can we enable the code coverage for all modules?
>
In theory we are running the full suite as we are using -Dstream.
I will double check
Enrico
> - Sijie
>
> On Mon, Jul 30, 2018 at 7:46 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Code coverage report restored !
> >
> > We are back to 72%
> >
> > see
> > https://coveralls.io/github/apache/bookkeeper
> >
> > Thank you JV, Sijie and Ivan !!
> >
> > Enrico
> >
> >
> >
> > Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli <
> > eolivelli@gmail.com> ha scritto:
> >
> > > Here it is the patch
> > >
> > > Please Sijie take a look.
> > > I would like to restore Coveralls before releasing 4.8
> > >
> > > Thanks
> > > Enrico
> > >
> > > Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
> > > eolivelli@gmail.com> ha scritto:
> > >
> > >>
> > >>
> > >> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <jujjuri@gmail.com
> >
> > >> ha scritto:
> > >>
> > >>> I don't see bookkeeper-server in the
> > >>> https://coveralls.io/builds/17501203
> > >>> report. Rest looks almost identical.
> > >>> That must be causing the overall drop.
> > >>>
> > >>
> > >> Thank you.
> > >> I have an idea, that change introduced a specific configuration for
> > >> surefire, the maven plugin which executes tests. Maybe it is disabling
> > >> JaCoCo agent.
> > >>
> > >> I will be back with news and hopefully a patch
> > >>
> > >> Enrico
> > >>
> > >>
> > >>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <
> eolivelli@gmail.com>
> > >>> wrote:
> > >>>
> > >>> > Hi,
> > >>> > In June, the 14th, code coverage dropped
> > >>> >
> > >>> > here: 72%
> > >>> > https://coveralls.io/builds/17447847
> > >>> >
> > >>> > here: 54%
> > >>> > https://coveralls.io/builds/17501203
> > >>> >
> > >>> > This commit seems the cause (as reported by Coveralls.io)
> > >>> >
> > >>>
> >
> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
> > >>> > 7eb80bd64e
> > >>> >
> > >>> > Anyone has cycles to take a look ?
> > >>> >
> > >>> >
> > >>> > Enrico
> > >>> >
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Jvrao
> > >>> ---
> > >>> First they ignore you, then they laugh at you, then they fight you,
> > then
> > >>> you win. - Mahatma Gandhi
> > >>>
> > >> --
> > >>
> > >>
> > >> -- Enrico Olivelli
> > >>
> > >
> >
>
--
-- Enrico Olivelli
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Sijie Guo <gu...@gmail.com>.
Great work, Enrico!
Can we enable the code coverage for all modules?
- Sijie
On Mon, Jul 30, 2018 at 7:46 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Code coverage report restored !
>
> We are back to 72%
>
> see
> https://coveralls.io/github/apache/bookkeeper
>
> Thank you JV, Sijie and Ivan !!
>
> Enrico
>
>
>
> Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
> > Here it is the patch
> >
> > Please Sijie take a look.
> > I would like to restore Coveralls before releasing 4.8
> >
> > Thanks
> > Enrico
> >
> > Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
> > eolivelli@gmail.com> ha scritto:
> >
> >>
> >>
> >> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <ju...@gmail.com>
> >> ha scritto:
> >>
> >>> I don't see bookkeeper-server in the
> >>> https://coveralls.io/builds/17501203
> >>> report. Rest looks almost identical.
> >>> That must be causing the overall drop.
> >>>
> >>
> >> Thank you.
> >> I have an idea, that change introduced a specific configuration for
> >> surefire, the maven plugin which executes tests. Maybe it is disabling
> >> JaCoCo agent.
> >>
> >> I will be back with news and hopefully a patch
> >>
> >> Enrico
> >>
> >>
> >>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eo...@gmail.com>
> >>> wrote:
> >>>
> >>> > Hi,
> >>> > In June, the 14th, code coverage dropped
> >>> >
> >>> > here: 72%
> >>> > https://coveralls.io/builds/17447847
> >>> >
> >>> > here: 54%
> >>> > https://coveralls.io/builds/17501203
> >>> >
> >>> > This commit seems the cause (as reported by Coveralls.io)
> >>> >
> >>>
> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
> >>> > 7eb80bd64e
> >>> >
> >>> > Anyone has cycles to take a look ?
> >>> >
> >>> >
> >>> > Enrico
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Jvrao
> >>> ---
> >>> First they ignore you, then they laugh at you, then they fight you,
> then
> >>> you win. - Mahatma Gandhi
> >>>
> >> --
> >>
> >>
> >> -- Enrico Olivelli
> >>
> >
>
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Enrico Olivelli <eo...@gmail.com>.
Code coverage report restored !
We are back to 72%
see
https://coveralls.io/github/apache/bookkeeper
Thank you JV, Sijie and Ivan !!
Enrico
Il giorno mar 24 lug 2018 alle ore 20:38 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:
> Here it is the patch
>
> Please Sijie take a look.
> I would like to restore Coveralls before releasing 4.8
>
> Thanks
> Enrico
>
> Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
>>
>>
>> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <ju...@gmail.com>
>> ha scritto:
>>
>>> I don't see bookkeeper-server in the
>>> https://coveralls.io/builds/17501203
>>> report. Rest looks almost identical.
>>> That must be causing the overall drop.
>>>
>>
>> Thank you.
>> I have an idea, that change introduced a specific configuration for
>> surefire, the maven plugin which executes tests. Maybe it is disabling
>> JaCoCo agent.
>>
>> I will be back with news and hopefully a patch
>>
>> Enrico
>>
>>
>>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>>
>>> > Hi,
>>> > In June, the 14th, code coverage dropped
>>> >
>>> > here: 72%
>>> > https://coveralls.io/builds/17447847
>>> >
>>> > here: 54%
>>> > https://coveralls.io/builds/17501203
>>> >
>>> > This commit seems the cause (as reported by Coveralls.io)
>>> >
>>> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
>>> > 7eb80bd64e
>>> >
>>> > Anyone has cycles to take a look ?
>>> >
>>> >
>>> > Enrico
>>> >
>>>
>>>
>>>
>>> --
>>> Jvrao
>>> ---
>>> First they ignore you, then they laugh at you, then they fight you, then
>>> you win. - Mahatma Gandhi
>>>
>> --
>>
>>
>> -- Enrico Olivelli
>>
>
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Enrico Olivelli <eo...@gmail.com>.
Here it is the patch
Please Sijie take a look.
I would like to restore Coveralls before releasing 4.8
Thanks
Enrico
Il giorno mar 24 lug 2018 alle ore 20:10 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:
>
>
> Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <ju...@gmail.com> ha
> scritto:
>
>> I don't see bookkeeper-server in the https://coveralls.io/builds/17501203
>> report. Rest looks almost identical.
>> That must be causing the overall drop.
>>
>
> Thank you.
> I have an idea, that change introduced a specific configuration for
> surefire, the maven plugin which executes tests. Maybe it is disabling
> JaCoCo agent.
>
> I will be back with news and hopefully a patch
>
> Enrico
>
>
>> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Hi,
>> > In June, the 14th, code coverage dropped
>> >
>> > here: 72%
>> > https://coveralls.io/builds/17447847
>> >
>> > here: 54%
>> > https://coveralls.io/builds/17501203
>> >
>> > This commit seems the cause (as reported by Coveralls.io)
>> >
>> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
>> > 7eb80bd64e
>> >
>> > Anyone has cycles to take a look ?
>> >
>> >
>> > Enrico
>> >
>>
>>
>>
>> --
>> Jvrao
>> ---
>> First they ignore you, then they laugh at you, then they fight you, then
>> you win. - Mahatma Gandhi
>>
> --
>
>
> -- Enrico Olivelli
>
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Enrico Olivelli <eo...@gmail.com>.
Il mar 24 lug 2018, 18:00 Venkateswara Rao Jujjuri <ju...@gmail.com> ha
scritto:
> I don't see bookkeeper-server in the https://coveralls.io/builds/17501203
> report. Rest looks almost identical.
> That must be causing the overall drop.
>
Thank you.
I have an idea, that change introduced a specific configuration for
surefire, the maven plugin which executes tests. Maybe it is disabling
JaCoCo agent.
I will be back with news and hopefully a patch
Enrico
> On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hi,
> > In June, the 14th, code coverage dropped
> >
> > here: 72%
> > https://coveralls.io/builds/17447847
> >
> > here: 54%
> > https://coveralls.io/builds/17501203
> >
> > This commit seems the cause (as reported by Coveralls.io)
> >
> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
> > 7eb80bd64e
> >
> > Anyone has cycles to take a look ?
> >
> >
> > Enrico
> >
>
>
>
> --
> Jvrao
> ---
> First they ignore you, then they laugh at you, then they fight you, then
> you win. - Mahatma Gandhi
>
--
-- Enrico Olivelli
Re: BookKeeper code coverage incredibly dropped in June from 72% to
54% !!
Posted by Venkateswara Rao Jujjuri <ju...@gmail.com>.
I don't see bookkeeper-server in the https://coveralls.io/builds/17501203
report. Rest looks almost identical.
That must be causing the overall drop.
On Tue, Jul 24, 2018 at 8:20 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Hi,
> In June, the 14th, code coverage dropped
>
> here: 72%
> https://coveralls.io/builds/17447847
>
> here: 54%
> https://coveralls.io/builds/17501203
>
> This commit seems the cause (as reported by Coveralls.io)
> https://github.com/apache/bookkeeper/commit/c5a36219bbb7cfce343137bf3c361f
> 7eb80bd64e
>
> Anyone has cycles to take a look ?
>
>
> Enrico
>
--
Jvrao
---
First they ignore you, then they laugh at you, then they fight you, then
you win. - Mahatma Gandhi