You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/03 17:46:49 UTC

[GitHub] [couchdb] nickva commented on a change in pull request #3397: Allow applying per-transaction options with fabric2_fdb:transactional/3

nickva commented on a change in pull request #3397:
URL: https://github.com/apache/couchdb/pull/3397#discussion_r586640309



##########
File path: src/fabric/test/fabric2_tx_options_tests.erl
##########
@@ -101,9 +103,40 @@ can_configure_options_at_runtime(_) ->
     ok = fabric2_db:delete(DbName, [?ADMIN_CTX]).
 
 
+can_apply_options_to_db_name_transactions(_) ->
+    DbName = ?tempdb(),
+
+    TxFun = fun(TxDb) ->
+        #{tx := Tx} = TxDb,
+        fabric2_fdb:create(TxDb, [?ADMIN_CTX]),
+        erlfdb:wait(erlfdb:get(Tx, <<16#FF, "/primaryDatacenter">>))
+    end,
+    TxOpts = #{read_system_keys => <<>>},

Review comment:
       yeah that was a bit confusing, I had set it to `true` initially but we're following the C API pretty closely




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org