[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5163: add entity-type to message when no UUID is found for a DB ID

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5163:
URL: https://github.com/apache/cloudstack/pull/5163#discussion_r662882528



##########
File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java
##########
@@ -119,7 +119,9 @@ public boolean IsUuidFormat(String uuid) {
         }
         Identity identity = (Identity) this._entityMgr.findById(entityType, customId);
         if (identity == null) {
-            throw new InvalidParameterValueException("Unable to find UUID for id " + customId);
+            throw new InvalidParameterValueException(String.format("Unable to find UUID for id %s of type %s",
+                                                                   customId,
+                                                                   (entityType == null ? "<unknown type>" ? entityType.getSimpleName())));

Review comment:
       I am open to alternatives, but I don't like the <null>, how about just "unknown"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org