[GitHub] [beam] sjvanrossum commented on a diff in pull request #26948: Add topicPattern property to KafkaIO.Read to match topics using a regex

["sjvanrossum (via GitHub)" <gi...@apache.org>]

sjvanrossum commented on code in PR #26948:
URL: https://github.com/apache/beam/pull/26948#discussion_r1211742600


##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1578,15 +1604,30 @@ static class GenerateKafkaSourceDescriptor extends DoFn<byte[], KafkaSourceDescr
 
       @VisibleForTesting final @Nullable List<String> topics;
 
+      private final @Nullable Pattern topicPattern;

Review Comment:
   Not annotated with `@VisibleForTesting` since the property is not accessed directly in tests, but neither are the properties which do specify `@VisibleForTesting`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org