You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2007/10/09 11:33:07 UTC
Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c
On 10/09/2007 01:47 AM, niq@apache.org wrote:
> Author: niq
> Date: Mon Oct 8 16:47:35 2007
> New Revision: 583002
>
> URL: http://svn.apache.org/viewvc?rev=583002&view=rev
> Log:
> mod_proxy_http: Don't unescape/escape forward proxied URLs. Just check them.
> PR 42592
>
> also add fix to PR42572 to CHANGES (from r563487/r563489)
>
> Modified:
> httpd/httpd/trunk/CHANGES
> httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=583002&r1=583001&r2=583002&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Mon Oct 8 16:47:35 2007
> @@ -36,6 +36,9 @@
> const char *err;
> const char *scheme;
> apr_port_t port, def_port;
> + const char *p;
> + const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed+reserved from
> + ap_proxy_canonenc */
*allowed could be made 'static'.
Otherwise looks good.
Regards
Rüdiger
>
Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Oct 9, 2007, at 10:58 AM, William A. Rowe, Jr. wrote:
> Jim Jagielski wrote:
>>
>> On Oct 9, 2007, at 5:33 AM, Ruediger Pluem wrote:
>>
>>>> + const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed
>>>> +reserved
>>>> from
>>>> +
>>>> ap_proxy_canonenc */
>>>
>>> Otherwise looks good.
>>>
>>
>> Would almost make sense to have this as an API function... anyone
>> have
>> issues if I make the required adjustments for that to happen?
>
> Uhm - isn't this what uri_delims is for???
>
We're not looking for deliminators, we're looking for "invalid"
chars in a URL. So something like ap_proxy_validurl() or
ap_proxy_good_encoding()...
I can think of a few places where we'd want to replicate and
reuse this...
Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jim Jagielski wrote:
>
> On Oct 9, 2007, at 5:33 AM, Ruediger Pluem wrote:
>
>>> + const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed+reserved
>>> from
>>> + ap_proxy_canonenc */
>>
>> Otherwise looks good.
>>
>
> Would almost make sense to have this as an API function... anyone have
> issues if I make the required adjustments for that to happen?
Uhm - isn't this what uri_delims is for???
Bill
Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES
modules/proxy/mod_proxy_http.c
Posted by Nick Kew <ni...@webthing.com>.
On Tue, 9 Oct 2007 09:03:59 -0400
Jim Jagielski <ji...@jaguNET.com> wrote:
> Would almost make sense to have this as an API function... anyone have
> issues if I make the required adjustments for that to happen?
What's the scope of your proposed API function?
The current http_proxy_canonenc, generalised to serve also for
balancer_proxy_canonenc, ajp_proxy_canonenc, etc?
If so, sounds good to me. The thought had crossed my mind,
but is a definite Not Yet on my to-do list.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
Re: svn commit: r583002 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Oct 9, 2007, at 5:33 AM, Ruediger Pluem wrote:
>
>
> On 10/09/2007 01:47 AM, niq@apache.org wrote:
>> Author: niq
>> Date: Mon Oct 8 16:47:35 2007
>> New Revision: 583002
>>
>> URL: http://svn.apache.org/viewvc?rev=583002&view=rev
>> Log:
>> mod_proxy_http: Don't unescape/escape forward proxied URLs. Just
>> check them.
>> PR 42592
>>
>> also add fix to PR42572 to CHANGES (from r563487/r563489)
>>
>> Modified:
>> httpd/httpd/trunk/CHANGES
>> httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>>
>
>> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/
>> mod_proxy_http.c?rev=583002&r1=583001&r2=583002&view=diff
>> =====================================================================
>> =========
>> --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Mon Oct 8
>> 16:47:35 2007
>> @@ -36,6 +36,9 @@
>> const char *err;
>> const char *scheme;
>> apr_port_t port, def_port;
>> + const char *p;
>> + const char *allowed = "~$-_.+!*'(),;:@&=/"; /* allowed
>> +reserved from
>> +
>> ap_proxy_canonenc */
>
> *allowed could be made 'static'.
>
> Otherwise looks good.
>
Would almost make sense to have this as an API function... anyone have
issues if I make the required adjustments for that to happen?