[GitHub] [superset] AAfghahi commented on a change in pull request #16628: feat: Add Private Google Sheets to dynamic form

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #16628:
URL: https://github.com/apache/superset/pull/16628#discussion_r715149101



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -88,9 +105,40 @@ const CredentialsInfo = ({
   const [fileToUpload, setFileToUpload] = useState<string | null | undefined>(
     null,
   );
+  const [isPublic, setIsPublic] = useState<boolean>(true);
+  const showCredentialsInfo =
+    db?.engine === 'gsheets' ? !isEditMode && !isPublic : !isEditMode;
+  const isEncrypted = db?.encrypted_extra && db?.encrypted_extra?.length > 2;

Review comment:
       in the backend we make encrypted_extra into a string of an empty object. So "{}". 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org