You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/05 05:42:14 UTC

[GitHub] [incubator-nuttx] YuuichiNakamura commented on a change in pull request #1377: Add task trace support

YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r465485517



##########
File path: drivers/syslog/note_driver.c
##########
@@ -138,6 +185,231 @@ static ssize_t note_read(FAR struct file *filep, FAR char *buffer,
   sched_unlock();
   return retlen;
 }
+#endif
+
+/****************************************************************************
+ * Name: note_write
+ ****************************************************************************/
+
+#ifdef CONFIG_SCHED_INSTRUMENTATION_FILTER
+static ssize_t note_write(FAR struct file *filep, FAR const char *buffer,

Review comment:
       It is the remaining part when I had removed sched_note_message support commented at https://github.com/apache/incubator-nuttx/pull/1377#discussion_r451710712 .
   I'll remove note_write completely.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org