You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-commits@xmlgraphics.apache.org by de...@apache.org on 2006/09/08 13:45:08 UTC
svn commit: r441479 - in /xmlgraphics/batik/trunk/sources/org/apache/batik:
dom/svg/SVGOMAnimatedPathData.java transcoder/XMLAbstractTranscoder.java
Author: deweese
Date: Fri Sep 8 04:45:08 2006
New Revision: 441479
URL: http://svn.apache.org/viewvc?view=rev&rev=441479
Log:
1) Fixed significant performance bug in creating geometry (it was
parsing the entire path for each entry in the path, O(N^2) ).
2) Fixed bug #40405 (Thanks Kirill!)
Modified:
xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/SVGOMAnimatedPathData.java
xmlgraphics/batik/trunk/sources/org/apache/batik/transcoder/XMLAbstractTranscoder.java
Modified: xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/SVGOMAnimatedPathData.java
URL: http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/SVGOMAnimatedPathData.java?view=diff&rev=441479&r1=441478&r2=441479
==============================================================================
--- xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/SVGOMAnimatedPathData.java (original)
+++ xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/SVGOMAnimatedPathData.java Fri Sep 8 04:45:08 2006
@@ -292,10 +292,11 @@
itemList = builder.getList();
} catch (ParseException e) {
itemList = new ArrayList(1);
- valid = true;
throw new LiveAttributeException
(element, localName,
LiveAttributeException.ERR_ATTRIBUTE_MALFORMED, s);
+ } finally {
+ valid = true;
}
}
}
@@ -371,12 +372,12 @@
itemList = builder.getList();
} catch (ParseException e) {
itemList = new ArrayList(1);
- valid = true;
throw new LiveAttributeException
(element, localName,
LiveAttributeException.ERR_ATTRIBUTE_MALFORMED, s);
+ } finally {
+ valid = true;
}
- valid = true;
}
}
Modified: xmlgraphics/batik/trunk/sources/org/apache/batik/transcoder/XMLAbstractTranscoder.java
URL: http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/sources/org/apache/batik/transcoder/XMLAbstractTranscoder.java?view=diff&rev=441479&r1=441478&r2=441479
==============================================================================
--- xmlgraphics/batik/trunk/sources/org/apache/batik/transcoder/XMLAbstractTranscoder.java (original)
+++ xmlgraphics/batik/trunk/sources/org/apache/batik/transcoder/XMLAbstractTranscoder.java Fri Sep 8 04:45:08 2006
@@ -132,7 +132,6 @@
} catch (DOMException ex) {
handler.fatalError(new TranscoderException(ex));
} catch (IOException ex) {
- ex.printStackTrace();
handler.fatalError(new TranscoderException(ex));
}
}