You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/10/23 23:41:59 UTC

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 2:41 p.m.)


Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.


Changes
-------

Fixed exclusion filters for all platforms. Got Jenkins working https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/.


Bugs: MESOS-3313
    https://issues.apache.org/jira/browse/MESOS-3313


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
  support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/jenkins_build_docker.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/37787/diff/


Testing (updated)
-------

`jenkins-build-docker.sh` is a reworked version of the original `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing Mesos distributions. 

Features:
 * Runs libevent, SSL and ROOT tests.
 * Easily add OS/compiler Docker images for testing Mesos.
 * Exclude tests on per-image basis.
 * Easily reproduce the test image locally.
 * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).

How to run

The following environment variables have to be set for the script to run:
 * OS - OS name/version. Currently images are available for ubuntu-14.04, ubuntu-12.04, centos-7.1.
 * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
 * COMPILER - Compiler name/version. Currently available images include gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04.

Examples:
`OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' COMPILER=clang-3.6 ./jenkins_build_docker.sh`
`OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' ./jenkins_build_docker.sh`

Working integration with Jenkins: https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/


Thanks,

Artem Harutyunyan


Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/#review103889
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39604, 37787]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 9:43 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37787/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 9:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3313
>     https://issues.apache.org/jira/browse/MESOS-3313
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
>   support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/jenkins_build_docker.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37787/diff/
> 
> 
> Testing
> -------
> 
> `jenkins-build-docker.sh` is a reworked version of the original `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing Mesos distributions. 
> 
> Features:
>  * Runs libevent, SSL and ROOT tests.
>  * Easily add OS/compiler Docker images for testing Mesos.
>  * Exclude tests on per-image basis.
>  * Easily reproduce the test image locally.
>  * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).
> 
> How to run
> 
> The following environment variables have to be set for the script to run:
>  * OS - OS name/version. Currently images are available for ubuntu-14.04, ubuntu-12.04, centos-7.1.
>  * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
>  * COMPILER - Compiler name/version. Currently available images include gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04.
> 
> Examples:
> `OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' COMPILER=clang-3.6 ./jenkins_build_docker.sh`
> `OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' ./jenkins_build_docker.sh`
> 
> Working integration with [ASF Jenkins](https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/)
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 2:43 p.m.)


Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.


Bugs: MESOS-3313
    https://issues.apache.org/jira/browse/MESOS-3313


Repository: mesos


Description
-------

See summary.


Diffs
-----

  Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
  support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/jenkins_build_docker.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/37787/diff/


Testing (updated)
-------

`jenkins-build-docker.sh` is a reworked version of the original `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing Mesos distributions. 

Features:
 * Runs libevent, SSL and ROOT tests.
 * Easily add OS/compiler Docker images for testing Mesos.
 * Exclude tests on per-image basis.
 * Easily reproduce the test image locally.
 * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).

How to run

The following environment variables have to be set for the script to run:
 * OS - OS name/version. Currently images are available for ubuntu-14.04, ubuntu-12.04, centos-7.1.
 * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
 * COMPILER - Compiler name/version. Currently available images include gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04.

Examples:
`OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' COMPILER=clang-3.6 ./jenkins_build_docker.sh`
`OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' ./jenkins_build_docker.sh`

Working integration with [ASF Jenkins](https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/)


Thanks,

Artem Harutyunyan