You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by mkedwards <gi...@git.apache.org> on 2018/11/23 15:19:35 UTC

[GitHub] zookeeper pull request #719: [ZOOKEEPER-2778] QuorumPeer: address potential ...

GitHub user mkedwards opened a pull request:

    https://github.com/apache/zookeeper/pull/719

    [ZOOKEEPER-2778] QuorumPeer: address potential reconfiguration deadlocks

    * QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference
    * QuorumPeer/QuorumCnxManager: address deadlock and visibility issues
    * QuorumPeer: add fast path for already-non-null quorum/election address
    * QuorumPeer: fix access to newly private data members from ReconfigTest
    * LeaderBeanTest: set up mock QuorumVerifier so that addresses get set
    * QuorumPeer: warn when clobbering existing election algorithm
    * QuorumPeer: halt old QCM when clobbering existing election algorithm

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mkedwards/zookeeper ZOOKEEPER-2778-for-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #719
    
----
commit 53ab259c38ee4d33c8f3ab26cde82992e2074537
Author: Michael Edwards <me...@...>
Date:   2018-11-20T13:33:09Z

    [ZOOKEEPER-2778] QuorumPeer: address potential deadlocks related to reconfiguration
    
    * QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference
    * QuorumPeer/QuorumCnxManager: address deadlock and visibility issues
    * QuorumPeer: add fast path for already-non-null quorum/election address
    * QuorumPeer: fix access to newly private data members from ReconfigTest
    * LeaderBeanTest: set up mock QuorumVerifier so that addresses get set
    * QuorumPeer: warn when clobbering existing election algorithm
    * QuorumPeer: halt old QCM when clobbering existing election algorithm

----


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by mkedwards <gi...@git.apache.org>.
Github user mkedwards commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    I don't understand the test failures.  Are these unrelated problems in master?


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    @anmolnar yes, it is okay


---

[GitHub] zookeeper pull request #719: [ZOOKEEPER-2778] QuorumPeer: address potential ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/719


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    I'm waiting for @eolivelli 's feedback on the other PR.


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by mkedwards <gi...@git.apache.org>.
Github user mkedwards commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    I believe #707 has @eolivelli's LGTM now.


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    retest this please


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    Committed to master branch. Thanks @mkedwards !
    It hasn't applied cleanly to 3.5, so I'll commit #707 separately.


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by mkedwards <gi...@git.apache.org>.
Github user mkedwards commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    Does this look fit to merge?  I'm not a committer, so I'll need help getting it merged.  (The version targeted to branch-3.5 is #707.)


---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/719
  
    @mkedwards flakies


---