You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/08 19:21:05 UTC

[GitHub] [incubator-nuttx] johannes-nivus commented on issue #120: tools/nxstyle.c: FALSE alarms on right hand aligned comments.

johannes-nivus commented on issue #120: tools/nxstyle.c:  FALSE alarms on right hand aligned comments.
URL: https://github.com/apache/incubator-nuttx/issues/120#issuecomment-596241649
 
 
   @patacongo I had again a little fun with nxstyle this afternoon.
   I addressed Issue #120 and the problem had been quite simple: The prevbrhcmt had to propagate over preprocessor lines.
   Additionally I added checks for the column position of the right of code comments. (And caught one in include/nuttx/can/can.h)
   I don't want to file a PR without review (I fear your instant merging powers). So please take a look at
   https://github.com/johannes-nivus/incubator-nuttx/tree/nxstyle and review.
   Regards, Johannes  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services