You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/12/17 15:19:04 UTC

[PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

raulcd opened a new pull request, #45046:
URL: https://github.com/apache/arrow/pull/45046

   ### Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ### What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ### Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ### Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
   -->
   <!-- **This PR includes breaking changes to public APIs.** -->
   
   <!--
   Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
   -->
   <!-- **This PR contains a "Critical Fix".** -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548803410

   @github-actions crossbow submit wheel-manylinux-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45046:
URL: https://github.com/apache/arrow/pull/45046


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548816351

   @github-actions crossbow submit wheel-macos-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548827202

   Revision: 6eb504238cb81dec2e8437e70269a532dd7eeb88
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-ad62b7a323](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ad62b7a323)
   
   |Task|Status|
   |----|------|
   |wheel-macos-monterey-cp310-cp310-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp310-cp310-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521345/job/34543828021)|
   |wheel-macos-monterey-cp310-cp310-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp310-cp310-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521668/job/34543829283)|
   |wheel-macos-monterey-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521723/job/34543829862)|
   |wheel-macos-monterey-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521715/job/34543829815)|
   |wheel-macos-monterey-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376526095/job/34543842014)|
   |wheel-macos-monterey-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376528734/job/34543851176)|
   |wheel-macos-monterey-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376524991/job/34543838790)|
   |wheel-macos-monterey-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521396/job/34543828058)|
   |wheel-macos-monterey-cp313-cp313t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp313-cp313t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376528848/job/34543851126)|
   |wheel-macos-monterey-cp313-cp313t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp313-cp313t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376525193/job/34543839946)|
   |wheel-macos-monterey-cp39-cp39-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp39-cp39-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376521524/job/34543828200)|
   |wheel-macos-monterey-cp39-cp39-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ad62b7a323-github-wheel-macos-monterey-cp39-cp39-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376527065/job/34543845441)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548738116

   @github-actions crossbow submit wheel-manylinux-2-28-cp312-cp312-amd64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548802874

   We can see on the new logs, and is not downloaded/built anymore:
   ```
    -- Found orcAlt: /opt/vcpkg/installed/amd64-linux-static-release/lib/liborc.a (found version "2.0.0")
   -- Providing CMake module for FindorcAlt as part of Arrow CMake package
   -- Found ORC static library: /opt/vcpkg/installed/amd64-linux-static-release/lib/liborc.a
   -- Found ORC headers: /opt/vcpkg/installed/amd64-linux-static-release/include
   ```
   the orc tests on pyarrow being successful:
   ```
   usr/local/lib/python3.12/site-packages/pyarrow/tests/test_orc.py ....... [ 86%]
   ......                                                                   [ 87%]
   ```
   Previously it was built and we could see both the build process and the following log:
   ```
    -- Building Apache ORC from source
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548744122

   Revision: 6eb504238cb81dec2e8437e70269a532dd7eeb88
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-b309acbcb8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b309acbcb8)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-b309acbcb8-github-wheel-manylinux-2-28-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376012492/job/34542141934)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2548810086

   Revision: 6eb504238cb81dec2e8437e70269a532dd7eeb88
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-a95168b3c6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a95168b3c6)
   
   |Task|Status|
   |----|------|
   |wheel-manylinux-2-28-cp310-cp310-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp310-cp310-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444886/job/34543590089)|
   |wheel-manylinux-2-28-cp310-cp310-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp310-cp310-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444492/job/34543588468)|
   |wheel-manylinux-2-28-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444476/job/34543588409)|
   |wheel-manylinux-2-28-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444596/job/34543589681)|
   |wheel-manylinux-2-28-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444237/job/34543587276)|
   |wheel-manylinux-2-28-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444223/job/34543586831)|
   |wheel-manylinux-2-28-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444520/job/34543588467)|
   |wheel-manylinux-2-28-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444491/job/34543589708)|
   |wheel-manylinux-2-28-cp313-cp313t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp313-cp313t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444531/job/34543588796)|
   |wheel-manylinux-2-28-cp313-cp313t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp313-cp313t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444547/job/34543589657)|
   |wheel-manylinux-2-28-cp39-cp39-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp39-cp39-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444207/job/34543586770)|
   |wheel-manylinux-2-28-cp39-cp39-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2-28-cp39-cp39-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444232/job/34543587078)|
   |wheel-manylinux-2014-cp310-cp310-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp310-cp310-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444728/job/34543590028)|
   |wheel-manylinux-2014-cp310-cp310-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp310-cp310-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444208/job/34543586768)|
   |wheel-manylinux-2014-cp311-cp311-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp311-cp311-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444690/job/34543588829)|
   |wheel-manylinux-2014-cp311-cp311-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp311-cp311-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444742/job/34543590015)|
   |wheel-manylinux-2014-cp312-cp312-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp312-cp312-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444573/job/34543589720)|
   |wheel-manylinux-2014-cp312-cp312-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp312-cp312-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376445149/job/34543591364)|
   |wheel-manylinux-2014-cp313-cp313-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp313-cp313-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444782/job/34543589991)|
   |wheel-manylinux-2014-cp313-cp313-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp313-cp313-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444220/job/34543586725)|
   |wheel-manylinux-2014-cp313-cp313t-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp313-cp313t-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444440/job/34543588427)|
   |wheel-manylinux-2014-cp313-cp313t-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp313-cp313t-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444518/job/34543588832)|
   |wheel-manylinux-2014-cp39-cp39-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp39-cp39-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444390/job/34543587872)|
   |wheel-manylinux-2014-cp39-cp39-arm64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-a95168b3c6-github-wheel-manylinux-2014-cp39-cp39-arm64)](https://github.com/ursacomputing/crossbow/actions/runs/12376444298/job/34543587243)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled on Linux and macOS [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45046:
URL: https://github.com/apache/arrow/pull/45046#issuecomment-2582528135

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6c9e7e7d6bfeda51e9c0022268fa7fee098124de.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/35427015102) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org