You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <ja...@gmail.com> on 2013/08/21 23:54:11 UTC
Patch for mmap + windows
Elizabeth and I have a patch to support our memory mapped offset index
files properly on Windows:
https://issues.apache.org/jira/browse/KAFKA-1008
Question: Do we want this on 0.8 or trunk? I would feel more comfortable
with it in trunk, but that means windows support in 0.8 is known to be
broken (as opposed to "not known to be broken but not known to be working
either" since we are not doing aggressive system testing on windows).
I would feel more comfortable doing the patch on 0.8 if there was someone
who would be willing to take on real load testing and/or production
operation on Windows so we could have some confidence that Kafka on Windows
actually works, otherwise this could just be the tip of the iceberg.
Also it would be great to get review on that patch regardless of the
destination.
-Jay
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Hi Sriram,
If Elizabeth isn't able to respond to your feedback, I wonder if you can
fix the patch and apply it?
It will be great to have this patch in 0.8.
Thanks,
Tim
On Mon, Sep 9, 2013 at 3:56 PM, Sriram Subramanian <
srsubramanian@linkedin.com> wrote:
> I did take a look at KAFKA-1008 a while back and added some comments.
>
> On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>
> >Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
> >issue for the checkpoint files.
> >
> >-Jay
> >
> >
> >On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
> ><ne...@gmail.com>wrote:
> >
> >> +1 for windows support on 0.8
> >>
> >> Thanks,
> >> Neha
> >>
> >>
> >> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
> >>
> >> > So guys, do we want to do these in 0.8? The first patch was a little
> >> > involved but I think it would be good to have windows support in 0.8
> >>and
> >> it
> >> > sounds like Tim is able to get things working after these changes.
> >> >
> >> > -Jay
> >> >
> >> >
> >> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
> >>wrote:
> >> >
> >> > > Btw, I've been running this patch in our cloud env and it's been
> >> working
> >> > > fine so far.
> >> > >
> >> > > I actually filed another bug as I saw another problem on windows
> >> locally
> >> > (
> >> > > https://issues.apache.org/jira/browse/KAFKA-1036).
> >> > >
> >> > > Tim
> >> > >
> >> > >
> >> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
> >> wrote:
> >> > >
> >> > > > That would be great!
> >> > > >
> >> > > > -Jay
> >> > > >
> >> > > >
> >> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> >> > wrote:
> >> > > >
> >> > > > > Hi Jay,
> >> > > > >
> >> > > > > I'm planning to test run Kafka on Windows in our test
> >>environments
> >> > > > > evaluating if it's suitable for production usage.
> >> > > > >
> >> > > > > I can provide feedback with the patch how well it works and if
> >>we
> >> > > > encounter
> >> > > > > any functional or perf problems.
> >> > > > >
> >> > > > > Tim
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <jay.kreps@gmail.com
> >
> >> > > wrote:
> >> > > > >
> >> > > > > > Elizabeth and I have a patch to support our memory mapped
> >>offset
> >> > > index
> >> > > > > > files properly on Windows:
> >> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> >> > > > > >
> >> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> >> > > > comfortable
> >> > > > > > with it in trunk, but that means windows support in 0.8 is
> >>known
> >> to
> >> > > be
> >> > > > > > broken (as opposed to "not known to be broken but not known
> >>to be
> >> > > > working
> >> > > > > > either" since we are not doing aggressive system testing on
> >> > windows).
> >> > > > > >
> >> > > > > > I would feel more comfortable doing the patch on 0.8 if there
> >>was
> >> > > > someone
> >> > > > > > who would be willing to take on real load testing and/or
> >> production
> >> > > > > > operation on Windows so we could have some confidence that
> >>Kafka
> >> on
> >> > > > > Windows
> >> > > > > > actually works, otherwise this could just be the tip of the
> >> > iceberg.
> >> > > > > >
> >> > > > > > Also it would be great to get review on that patch regardless
> >>of
> >> > the
> >> > > > > > destination.
> >> > > > > >
> >> > > > > > -Jay
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
>
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Hi Sriram,
If Elizabeth isn't able to respond to your feedback, I wonder if you can
fix the patch and apply it?
It will be great to have this patch in 0.8.
Thanks,
Tim
On Mon, Sep 9, 2013 at 3:56 PM, Sriram Subramanian <
srsubramanian@linkedin.com> wrote:
> I did take a look at KAFKA-1008 a while back and added some comments.
>
> On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>
> >Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
> >issue for the checkpoint files.
> >
> >-Jay
> >
> >
> >On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
> ><ne...@gmail.com>wrote:
> >
> >> +1 for windows support on 0.8
> >>
> >> Thanks,
> >> Neha
> >>
> >>
> >> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
> >>
> >> > So guys, do we want to do these in 0.8? The first patch was a little
> >> > involved but I think it would be good to have windows support in 0.8
> >>and
> >> it
> >> > sounds like Tim is able to get things working after these changes.
> >> >
> >> > -Jay
> >> >
> >> >
> >> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
> >>wrote:
> >> >
> >> > > Btw, I've been running this patch in our cloud env and it's been
> >> working
> >> > > fine so far.
> >> > >
> >> > > I actually filed another bug as I saw another problem on windows
> >> locally
> >> > (
> >> > > https://issues.apache.org/jira/browse/KAFKA-1036).
> >> > >
> >> > > Tim
> >> > >
> >> > >
> >> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
> >> wrote:
> >> > >
> >> > > > That would be great!
> >> > > >
> >> > > > -Jay
> >> > > >
> >> > > >
> >> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> >> > wrote:
> >> > > >
> >> > > > > Hi Jay,
> >> > > > >
> >> > > > > I'm planning to test run Kafka on Windows in our test
> >>environments
> >> > > > > evaluating if it's suitable for production usage.
> >> > > > >
> >> > > > > I can provide feedback with the patch how well it works and if
> >>we
> >> > > > encounter
> >> > > > > any functional or perf problems.
> >> > > > >
> >> > > > > Tim
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <jay.kreps@gmail.com
> >
> >> > > wrote:
> >> > > > >
> >> > > > > > Elizabeth and I have a patch to support our memory mapped
> >>offset
> >> > > index
> >> > > > > > files properly on Windows:
> >> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> >> > > > > >
> >> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> >> > > > comfortable
> >> > > > > > with it in trunk, but that means windows support in 0.8 is
> >>known
> >> to
> >> > > be
> >> > > > > > broken (as opposed to "not known to be broken but not known
> >>to be
> >> > > > working
> >> > > > > > either" since we are not doing aggressive system testing on
> >> > windows).
> >> > > > > >
> >> > > > > > I would feel more comfortable doing the patch on 0.8 if there
> >>was
> >> > > > someone
> >> > > > > > who would be willing to take on real load testing and/or
> >> production
> >> > > > > > operation on Windows so we could have some confidence that
> >>Kafka
> >> on
> >> > > > > Windows
> >> > > > > > actually works, otherwise this could just be the tip of the
> >> > iceberg.
> >> > > > > >
> >> > > > > > Also it would be great to get review on that patch regardless
> >>of
> >> > the
> >> > > > > > destination.
> >> > > > > >
> >> > > > > > -Jay
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
>
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Gotcha :)
Seems like this will be taken care of then.
Tim
On Mon, Sep 9, 2013 at 6:22 PM, Jay Kreps <ja...@gmail.com> wrote:
> I think Srirams complaint is that I haven't yet addressed his concerns :-)
>
> Sent from my iPhone
>
> On Sep 9, 2013, at 3:56 PM, Sriram Subramanian <sr...@linkedin.com>
> wrote:
>
> > I did take a look at KAFKA-1008 a while back and added some comments.
> >
> > On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
> >
> >> Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
> >> issue for the checkpoint files.
> >>
> >> -Jay
> >>
> >>
> >> On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
> >> <ne...@gmail.com>wrote:
> >>
> >>> +1 for windows support on 0.8
> >>>
> >>> Thanks,
> >>> Neha
> >>>
> >>>
> >>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com>
> wrote:
> >>>
> >>>> So guys, do we want to do these in 0.8? The first patch was a little
> >>>> involved but I think it would be good to have windows support in 0.8
> >>> and
> >>> it
> >>>> sounds like Tim is able to get things working after these changes.
> >>>>
> >>>> -Jay
> >>>>
> >>>>
> >>>> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
> >>> wrote:
> >>>>
> >>>>> Btw, I've been running this patch in our cloud env and it's been
> >>> working
> >>>>> fine so far.
> >>>>>
> >>>>> I actually filed another bug as I saw another problem on windows
> >>> locally
> >>>> (
> >>>>> https://issues.apache.org/jira/browse/KAFKA-1036).
> >>>>>
> >>>>> Tim
> >>>>>
> >>>>>
> >>>>> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
> >>> wrote:
> >>>>>
> >>>>>> That would be great!
> >>>>>>
> >>>>>> -Jay
> >>>>>>
> >>>>>>
> >>>>>> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>>> Hi Jay,
> >>>>>>>
> >>>>>>> I'm planning to test run Kafka on Windows in our test
> >>> environments
> >>>>>>> evaluating if it's suitable for production usage.
> >>>>>>>
> >>>>>>> I can provide feedback with the patch how well it works and if
> >>> we
> >>>>>> encounter
> >>>>>>> any functional or perf problems.
> >>>>>>>
> >>>>>>> Tim
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> >>>>> wrote:
> >>>>>>>
> >>>>>>>> Elizabeth and I have a patch to support our memory mapped
> >>> offset
> >>>>> index
> >>>>>>>> files properly on Windows:
> >>>>>>>> https://issues.apache.org/jira/browse/KAFKA-1008
> >>>>>>>>
> >>>>>>>> Question: Do we want this on 0.8 or trunk? I would feel more
> >>>>>> comfortable
> >>>>>>>> with it in trunk, but that means windows support in 0.8 is
> >>> known
> >>> to
> >>>>> be
> >>>>>>>> broken (as opposed to "not known to be broken but not known
> >>> to be
> >>>>>> working
> >>>>>>>> either" since we are not doing aggressive system testing on
> >>>> windows).
> >>>>>>>>
> >>>>>>>> I would feel more comfortable doing the patch on 0.8 if there
> >>> was
> >>>>>> someone
> >>>>>>>> who would be willing to take on real load testing and/or
> >>> production
> >>>>>>>> operation on Windows so we could have some confidence that
> >>> Kafka
> >>> on
> >>>>>>> Windows
> >>>>>>>> actually works, otherwise this could just be the tip of the
> >>>> iceberg.
> >>>>>>>>
> >>>>>>>> Also it would be great to get review on that patch regardless
> >>> of
> >>>> the
> >>>>>>>> destination.
> >>>>>>>>
> >>>>>>>> -Jay
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
I think Srirams complaint is that I haven't yet addressed his concerns :-)
Sent from my iPhone
On Sep 9, 2013, at 3:56 PM, Sriram Subramanian <sr...@linkedin.com> wrote:
> I did take a look at KAFKA-1008 a while back and added some comments.
>
> On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>
>> Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
>> issue for the checkpoint files.
>>
>> -Jay
>>
>>
>> On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
>> <ne...@gmail.com>wrote:
>>
>>> +1 for windows support on 0.8
>>>
>>> Thanks,
>>> Neha
>>>
>>>
>>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>>>
>>>> So guys, do we want to do these in 0.8? The first patch was a little
>>>> involved but I think it would be good to have windows support in 0.8
>>> and
>>> it
>>>> sounds like Tim is able to get things working after these changes.
>>>>
>>>> -Jay
>>>>
>>>>
>>>> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
>>> wrote:
>>>>
>>>>> Btw, I've been running this patch in our cloud env and it's been
>>> working
>>>>> fine so far.
>>>>>
>>>>> I actually filed another bug as I saw another problem on windows
>>> locally
>>>> (
>>>>> https://issues.apache.org/jira/browse/KAFKA-1036).
>>>>>
>>>>> Tim
>>>>>
>>>>>
>>>>> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
>>> wrote:
>>>>>
>>>>>> That would be great!
>>>>>>
>>>>>> -Jay
>>>>>>
>>>>>>
>>>>>> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
>>>> wrote:
>>>>>>
>>>>>>> Hi Jay,
>>>>>>>
>>>>>>> I'm planning to test run Kafka on Windows in our test
>>> environments
>>>>>>> evaluating if it's suitable for production usage.
>>>>>>>
>>>>>>> I can provide feedback with the patch how well it works and if
>>> we
>>>>>> encounter
>>>>>>> any functional or perf problems.
>>>>>>>
>>>>>>> Tim
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
>>>>> wrote:
>>>>>>>
>>>>>>>> Elizabeth and I have a patch to support our memory mapped
>>> offset
>>>>> index
>>>>>>>> files properly on Windows:
>>>>>>>> https://issues.apache.org/jira/browse/KAFKA-1008
>>>>>>>>
>>>>>>>> Question: Do we want this on 0.8 or trunk? I would feel more
>>>>>> comfortable
>>>>>>>> with it in trunk, but that means windows support in 0.8 is
>>> known
>>> to
>>>>> be
>>>>>>>> broken (as opposed to "not known to be broken but not known
>>> to be
>>>>>> working
>>>>>>>> either" since we are not doing aggressive system testing on
>>>> windows).
>>>>>>>>
>>>>>>>> I would feel more comfortable doing the patch on 0.8 if there
>>> was
>>>>>> someone
>>>>>>>> who would be willing to take on real load testing and/or
>>> production
>>>>>>>> operation on Windows so we could have some confidence that
>>> Kafka
>>> on
>>>>>>> Windows
>>>>>>>> actually works, otherwise this could just be the tip of the
>>>> iceberg.
>>>>>>>>
>>>>>>>> Also it would be great to get review on that patch regardless
>>> of
>>>> the
>>>>>>>> destination.
>>>>>>>>
>>>>>>>> -Jay
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
I think Srirams complaint is that I haven't yet addressed his concerns :-)
Sent from my iPhone
On Sep 9, 2013, at 3:56 PM, Sriram Subramanian <sr...@linkedin.com> wrote:
> I did take a look at KAFKA-1008 a while back and added some comments.
>
> On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>
>> Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
>> issue for the checkpoint files.
>>
>> -Jay
>>
>>
>> On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
>> <ne...@gmail.com>wrote:
>>
>>> +1 for windows support on 0.8
>>>
>>> Thanks,
>>> Neha
>>>
>>>
>>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>>>
>>>> So guys, do we want to do these in 0.8? The first patch was a little
>>>> involved but I think it would be good to have windows support in 0.8
>>> and
>>> it
>>>> sounds like Tim is able to get things working after these changes.
>>>>
>>>> -Jay
>>>>
>>>>
>>>> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
>>> wrote:
>>>>
>>>>> Btw, I've been running this patch in our cloud env and it's been
>>> working
>>>>> fine so far.
>>>>>
>>>>> I actually filed another bug as I saw another problem on windows
>>> locally
>>>> (
>>>>> https://issues.apache.org/jira/browse/KAFKA-1036).
>>>>>
>>>>> Tim
>>>>>
>>>>>
>>>>> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
>>> wrote:
>>>>>
>>>>>> That would be great!
>>>>>>
>>>>>> -Jay
>>>>>>
>>>>>>
>>>>>> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
>>>> wrote:
>>>>>>
>>>>>>> Hi Jay,
>>>>>>>
>>>>>>> I'm planning to test run Kafka on Windows in our test
>>> environments
>>>>>>> evaluating if it's suitable for production usage.
>>>>>>>
>>>>>>> I can provide feedback with the patch how well it works and if
>>> we
>>>>>> encounter
>>>>>>> any functional or perf problems.
>>>>>>>
>>>>>>> Tim
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
>>>>> wrote:
>>>>>>>
>>>>>>>> Elizabeth and I have a patch to support our memory mapped
>>> offset
>>>>> index
>>>>>>>> files properly on Windows:
>>>>>>>> https://issues.apache.org/jira/browse/KAFKA-1008
>>>>>>>>
>>>>>>>> Question: Do we want this on 0.8 or trunk? I would feel more
>>>>>> comfortable
>>>>>>>> with it in trunk, but that means windows support in 0.8 is
>>> known
>>> to
>>>>> be
>>>>>>>> broken (as opposed to "not known to be broken but not known
>>> to be
>>>>>> working
>>>>>>>> either" since we are not doing aggressive system testing on
>>>> windows).
>>>>>>>>
>>>>>>>> I would feel more comfortable doing the patch on 0.8 if there
>>> was
>>>>>> someone
>>>>>>>> who would be willing to take on real load testing and/or
>>> production
>>>>>>>> operation on Windows so we could have some confidence that
>>> Kafka
>>> on
>>>>>>> Windows
>>>>>>>> actually works, otherwise this could just be the tip of the
>>>> iceberg.
>>>>>>>>
>>>>>>>> Also it would be great to get review on that patch regardless
>>> of
>>>> the
>>>>>>>> destination.
>>>>>>>>
>>>>>>>> -Jay
>
Re: Patch for mmap + windows
Posted by Sriram Subramanian <sr...@linkedin.com>.
I did take a look at KAFKA-1008 a while back and added some comments.
On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
>issue for the checkpoint files.
>
>-Jay
>
>
>On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
><ne...@gmail.com>wrote:
>
>> +1 for windows support on 0.8
>>
>> Thanks,
>> Neha
>>
>>
>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>>
>> > So guys, do we want to do these in 0.8? The first patch was a little
>> > involved but I think it would be good to have windows support in 0.8
>>and
>> it
>> > sounds like Tim is able to get things working after these changes.
>> >
>> > -Jay
>> >
>> >
>> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
>>wrote:
>> >
>> > > Btw, I've been running this patch in our cloud env and it's been
>> working
>> > > fine so far.
>> > >
>> > > I actually filed another bug as I saw another problem on windows
>> locally
>> > (
>> > > https://issues.apache.org/jira/browse/KAFKA-1036).
>> > >
>> > > Tim
>> > >
>> > >
>> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
>> wrote:
>> > >
>> > > > That would be great!
>> > > >
>> > > > -Jay
>> > > >
>> > > >
>> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
>> > wrote:
>> > > >
>> > > > > Hi Jay,
>> > > > >
>> > > > > I'm planning to test run Kafka on Windows in our test
>>environments
>> > > > > evaluating if it's suitable for production usage.
>> > > > >
>> > > > > I can provide feedback with the patch how well it works and if
>>we
>> > > > encounter
>> > > > > any functional or perf problems.
>> > > > >
>> > > > > Tim
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
>> > > wrote:
>> > > > >
>> > > > > > Elizabeth and I have a patch to support our memory mapped
>>offset
>> > > index
>> > > > > > files properly on Windows:
>> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
>> > > > > >
>> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
>> > > > comfortable
>> > > > > > with it in trunk, but that means windows support in 0.8 is
>>known
>> to
>> > > be
>> > > > > > broken (as opposed to "not known to be broken but not known
>>to be
>> > > > working
>> > > > > > either" since we are not doing aggressive system testing on
>> > windows).
>> > > > > >
>> > > > > > I would feel more comfortable doing the patch on 0.8 if there
>>was
>> > > > someone
>> > > > > > who would be willing to take on real load testing and/or
>> production
>> > > > > > operation on Windows so we could have some confidence that
>>Kafka
>> on
>> > > > > Windows
>> > > > > > actually works, otherwise this could just be the tip of the
>> > iceberg.
>> > > > > >
>> > > > > > Also it would be great to get review on that patch regardless
>>of
>> > the
>> > > > > > destination.
>> > > > > >
>> > > > > > -Jay
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
Re: Patch for mmap + windows
Posted by Sriram Subramanian <sr...@linkedin.com>.
I did take a look at KAFKA-1008 a while back and added some comments.
On 9/9/13 3:52 PM, "Jay Kreps" <ja...@gmail.com> wrote:
>Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
>issue for the checkpoint files.
>
>-Jay
>
>
>On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
><ne...@gmail.com>wrote:
>
>> +1 for windows support on 0.8
>>
>> Thanks,
>> Neha
>>
>>
>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>>
>> > So guys, do we want to do these in 0.8? The first patch was a little
>> > involved but I think it would be good to have windows support in 0.8
>>and
>> it
>> > sounds like Tim is able to get things working after these changes.
>> >
>> > -Jay
>> >
>> >
>> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com>
>>wrote:
>> >
>> > > Btw, I've been running this patch in our cloud env and it's been
>> working
>> > > fine so far.
>> > >
>> > > I actually filed another bug as I saw another problem on windows
>> locally
>> > (
>> > > https://issues.apache.org/jira/browse/KAFKA-1036).
>> > >
>> > > Tim
>> > >
>> > >
>> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
>> wrote:
>> > >
>> > > > That would be great!
>> > > >
>> > > > -Jay
>> > > >
>> > > >
>> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
>> > wrote:
>> > > >
>> > > > > Hi Jay,
>> > > > >
>> > > > > I'm planning to test run Kafka on Windows in our test
>>environments
>> > > > > evaluating if it's suitable for production usage.
>> > > > >
>> > > > > I can provide feedback with the patch how well it works and if
>>we
>> > > > encounter
>> > > > > any functional or perf problems.
>> > > > >
>> > > > > Tim
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
>> > > wrote:
>> > > > >
>> > > > > > Elizabeth and I have a patch to support our memory mapped
>>offset
>> > > index
>> > > > > > files properly on Windows:
>> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
>> > > > > >
>> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
>> > > > comfortable
>> > > > > > with it in trunk, but that means windows support in 0.8 is
>>known
>> to
>> > > be
>> > > > > > broken (as opposed to "not known to be broken but not known
>>to be
>> > > > working
>> > > > > > either" since we are not doing aggressive system testing on
>> > windows).
>> > > > > >
>> > > > > > I would feel more comfortable doing the patch on 0.8 if there
>>was
>> > > > someone
>> > > > > > who would be willing to take on real load testing and/or
>> production
>> > > > > > operation on Windows so we could have some confidence that
>>Kafka
>> on
>> > > > > Windows
>> > > > > > actually works, otherwise this could just be the tip of the
>> > iceberg.
>> > > > > >
>> > > > > > Also it would be great to get review on that patch regardless
>>of
>> > the
>> > > > > > destination.
>> > > > > >
>> > > > > > -Jay
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
issue for the checkpoint files.
-Jay
On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede <ne...@gmail.com>wrote:
> +1 for windows support on 0.8
>
> Thanks,
> Neha
>
>
> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>
> > So guys, do we want to do these in 0.8? The first patch was a little
> > involved but I think it would be good to have windows support in 0.8 and
> it
> > sounds like Tim is able to get things working after these changes.
> >
> > -Jay
> >
> >
> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
> >
> > > Btw, I've been running this patch in our cloud env and it's been
> working
> > > fine so far.
> > >
> > > I actually filed another bug as I saw another problem on windows
> locally
> > (
> > > https://issues.apache.org/jira/browse/KAFKA-1036).
> > >
> > > Tim
> > >
> > >
> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
> wrote:
> > >
> > > > That would be great!
> > > >
> > > > -Jay
> > > >
> > > >
> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> > wrote:
> > > >
> > > > > Hi Jay,
> > > > >
> > > > > I'm planning to test run Kafka on Windows in our test environments
> > > > > evaluating if it's suitable for production usage.
> > > > >
> > > > > I can provide feedback with the patch how well it works and if we
> > > > encounter
> > > > > any functional or perf problems.
> > > > >
> > > > > Tim
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Elizabeth and I have a patch to support our memory mapped offset
> > > index
> > > > > > files properly on Windows:
> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > > > >
> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > > > comfortable
> > > > > > with it in trunk, but that means windows support in 0.8 is known
> to
> > > be
> > > > > > broken (as opposed to "not known to be broken but not known to be
> > > > working
> > > > > > either" since we are not doing aggressive system testing on
> > windows).
> > > > > >
> > > > > > I would feel more comfortable doing the patch on 0.8 if there was
> > > > someone
> > > > > > who would be willing to take on real load testing and/or
> production
> > > > > > operation on Windows so we could have some confidence that Kafka
> on
> > > > > Windows
> > > > > > actually works, otherwise this could just be the tip of the
> > iceberg.
> > > > > >
> > > > > > Also it would be great to get review on that patch regardless of
> > the
> > > > > > destination.
> > > > > >
> > > > > > -Jay
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
issue for the checkpoint files.
-Jay
On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede <ne...@gmail.com>wrote:
> +1 for windows support on 0.8
>
> Thanks,
> Neha
>
>
> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
>
> > So guys, do we want to do these in 0.8? The first patch was a little
> > involved but I think it would be good to have windows support in 0.8 and
> it
> > sounds like Tim is able to get things working after these changes.
> >
> > -Jay
> >
> >
> > On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
> >
> > > Btw, I've been running this patch in our cloud env and it's been
> working
> > > fine so far.
> > >
> > > I actually filed another bug as I saw another problem on windows
> locally
> > (
> > > https://issues.apache.org/jira/browse/KAFKA-1036).
> > >
> > > Tim
> > >
> > >
> > > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com>
> wrote:
> > >
> > > > That would be great!
> > > >
> > > > -Jay
> > > >
> > > >
> > > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> > wrote:
> > > >
> > > > > Hi Jay,
> > > > >
> > > > > I'm planning to test run Kafka on Windows in our test environments
> > > > > evaluating if it's suitable for production usage.
> > > > >
> > > > > I can provide feedback with the patch how well it works and if we
> > > > encounter
> > > > > any functional or perf problems.
> > > > >
> > > > > Tim
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> > > wrote:
> > > > >
> > > > > > Elizabeth and I have a patch to support our memory mapped offset
> > > index
> > > > > > files properly on Windows:
> > > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > > > >
> > > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > > > comfortable
> > > > > > with it in trunk, but that means windows support in 0.8 is known
> to
> > > be
> > > > > > broken (as opposed to "not known to be broken but not known to be
> > > > working
> > > > > > either" since we are not doing aggressive system testing on
> > windows).
> > > > > >
> > > > > > I would feel more comfortable doing the patch on 0.8 if there was
> > > > someone
> > > > > > who would be willing to take on real load testing and/or
> production
> > > > > > operation on Windows so we could have some confidence that Kafka
> on
> > > > > Windows
> > > > > > actually works, otherwise this could just be the tip of the
> > iceberg.
> > > > > >
> > > > > > Also it would be great to get review on that patch regardless of
> > the
> > > > > > destination.
> > > > > >
> > > > > > -Jay
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Neha Narkhede <ne...@gmail.com>.
+1 for windows support on 0.8
Thanks,
Neha
On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
> So guys, do we want to do these in 0.8? The first patch was a little
> involved but I think it would be good to have windows support in 0.8 and it
> sounds like Tim is able to get things working after these changes.
>
> -Jay
>
>
> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
>
> > Btw, I've been running this patch in our cloud env and it's been working
> > fine so far.
> >
> > I actually filed another bug as I saw another problem on windows locally
> (
> > https://issues.apache.org/jira/browse/KAFKA-1036).
> >
> > Tim
> >
> >
> > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
> >
> > > That would be great!
> > >
> > > -Jay
> > >
> > >
> > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> wrote:
> > >
> > > > Hi Jay,
> > > >
> > > > I'm planning to test run Kafka on Windows in our test environments
> > > > evaluating if it's suitable for production usage.
> > > >
> > > > I can provide feedback with the patch how well it works and if we
> > > encounter
> > > > any functional or perf problems.
> > > >
> > > > Tim
> > > >
> > > >
> > > >
> > > >
> > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> > wrote:
> > > >
> > > > > Elizabeth and I have a patch to support our memory mapped offset
> > index
> > > > > files properly on Windows:
> > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > > >
> > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > > comfortable
> > > > > with it in trunk, but that means windows support in 0.8 is known to
> > be
> > > > > broken (as opposed to "not known to be broken but not known to be
> > > working
> > > > > either" since we are not doing aggressive system testing on
> windows).
> > > > >
> > > > > I would feel more comfortable doing the patch on 0.8 if there was
> > > someone
> > > > > who would be willing to take on real load testing and/or production
> > > > > operation on Windows so we could have some confidence that Kafka on
> > > > Windows
> > > > > actually works, otherwise this could just be the tip of the
> iceberg.
> > > > >
> > > > > Also it would be great to get review on that patch regardless of
> the
> > > > > destination.
> > > > >
> > > > > -Jay
> > > > >
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Neha Narkhede <ne...@gmail.com>.
+1 for windows support on 0.8
Thanks,
Neha
On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <ja...@gmail.com> wrote:
> So guys, do we want to do these in 0.8? The first patch was a little
> involved but I think it would be good to have windows support in 0.8 and it
> sounds like Tim is able to get things working after these changes.
>
> -Jay
>
>
> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
>
> > Btw, I've been running this patch in our cloud env and it's been working
> > fine so far.
> >
> > I actually filed another bug as I saw another problem on windows locally
> (
> > https://issues.apache.org/jira/browse/KAFKA-1036).
> >
> > Tim
> >
> >
> > On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
> >
> > > That would be great!
> > >
> > > -Jay
> > >
> > >
> > > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com>
> wrote:
> > >
> > > > Hi Jay,
> > > >
> > > > I'm planning to test run Kafka on Windows in our test environments
> > > > evaluating if it's suitable for production usage.
> > > >
> > > > I can provide feedback with the patch how well it works and if we
> > > encounter
> > > > any functional or perf problems.
> > > >
> > > > Tim
> > > >
> > > >
> > > >
> > > >
> > > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> > wrote:
> > > >
> > > > > Elizabeth and I have a patch to support our memory mapped offset
> > index
> > > > > files properly on Windows:
> > > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > > >
> > > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > > comfortable
> > > > > with it in trunk, but that means windows support in 0.8 is known to
> > be
> > > > > broken (as opposed to "not known to be broken but not known to be
> > > working
> > > > > either" since we are not doing aggressive system testing on
> windows).
> > > > >
> > > > > I would feel more comfortable doing the patch on 0.8 if there was
> > > someone
> > > > > who would be willing to take on real load testing and/or production
> > > > > operation on Windows so we could have some confidence that Kafka on
> > > > Windows
> > > > > actually works, otherwise this could just be the tip of the
> iceberg.
> > > > >
> > > > > Also it would be great to get review on that patch regardless of
> the
> > > > > destination.
> > > > >
> > > > > -Jay
> > > > >
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
So guys, do we want to do these in 0.8? The first patch was a little
involved but I think it would be good to have windows support in 0.8 and it
sounds like Tim is able to get things working after these changes.
-Jay
On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
> Btw, I've been running this patch in our cloud env and it's been working
> fine so far.
>
> I actually filed another bug as I saw another problem on windows locally (
> https://issues.apache.org/jira/browse/KAFKA-1036).
>
> Tim
>
>
> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
>
> > That would be great!
> >
> > -Jay
> >
> >
> > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
> >
> > > Hi Jay,
> > >
> > > I'm planning to test run Kafka on Windows in our test environments
> > > evaluating if it's suitable for production usage.
> > >
> > > I can provide feedback with the patch how well it works and if we
> > encounter
> > > any functional or perf problems.
> > >
> > > Tim
> > >
> > >
> > >
> > >
> > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> wrote:
> > >
> > > > Elizabeth and I have a patch to support our memory mapped offset
> index
> > > > files properly on Windows:
> > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > >
> > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > comfortable
> > > > with it in trunk, but that means windows support in 0.8 is known to
> be
> > > > broken (as opposed to "not known to be broken but not known to be
> > working
> > > > either" since we are not doing aggressive system testing on windows).
> > > >
> > > > I would feel more comfortable doing the patch on 0.8 if there was
> > someone
> > > > who would be willing to take on real load testing and/or production
> > > > operation on Windows so we could have some confidence that Kafka on
> > > Windows
> > > > actually works, otherwise this could just be the tip of the iceberg.
> > > >
> > > > Also it would be great to get review on that patch regardless of the
> > > > destination.
> > > >
> > > > -Jay
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
So guys, do we want to do these in 0.8? The first patch was a little
involved but I think it would be good to have windows support in 0.8 and it
sounds like Tim is able to get things working after these changes.
-Jay
On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <tn...@gmail.com> wrote:
> Btw, I've been running this patch in our cloud env and it's been working
> fine so far.
>
> I actually filed another bug as I saw another problem on windows locally (
> https://issues.apache.org/jira/browse/KAFKA-1036).
>
> Tim
>
>
> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
>
> > That would be great!
> >
> > -Jay
> >
> >
> > On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
> >
> > > Hi Jay,
> > >
> > > I'm planning to test run Kafka on Windows in our test environments
> > > evaluating if it's suitable for production usage.
> > >
> > > I can provide feedback with the patch how well it works and if we
> > encounter
> > > any functional or perf problems.
> > >
> > > Tim
> > >
> > >
> > >
> > >
> > > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com>
> wrote:
> > >
> > > > Elizabeth and I have a patch to support our memory mapped offset
> index
> > > > files properly on Windows:
> > > > https://issues.apache.org/jira/browse/KAFKA-1008
> > > >
> > > > Question: Do we want this on 0.8 or trunk? I would feel more
> > comfortable
> > > > with it in trunk, but that means windows support in 0.8 is known to
> be
> > > > broken (as opposed to "not known to be broken but not known to be
> > working
> > > > either" since we are not doing aggressive system testing on windows).
> > > >
> > > > I would feel more comfortable doing the patch on 0.8 if there was
> > someone
> > > > who would be willing to take on real load testing and/or production
> > > > operation on Windows so we could have some confidence that Kafka on
> > > Windows
> > > > actually works, otherwise this could just be the tip of the iceberg.
> > > >
> > > > Also it would be great to get review on that patch regardless of the
> > > > destination.
> > > >
> > > > -Jay
> > > >
> > >
> >
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Btw, I've been running this patch in our cloud env and it's been working
fine so far.
I actually filed another bug as I saw another problem on windows locally (
https://issues.apache.org/jira/browse/KAFKA-1036).
Tim
On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
> That would be great!
>
> -Jay
>
>
> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
>
> > Hi Jay,
> >
> > I'm planning to test run Kafka on Windows in our test environments
> > evaluating if it's suitable for production usage.
> >
> > I can provide feedback with the patch how well it works and if we
> encounter
> > any functional or perf problems.
> >
> > Tim
> >
> >
> >
> >
> > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
> >
> > > Elizabeth and I have a patch to support our memory mapped offset index
> > > files properly on Windows:
> > > https://issues.apache.org/jira/browse/KAFKA-1008
> > >
> > > Question: Do we want this on 0.8 or trunk? I would feel more
> comfortable
> > > with it in trunk, but that means windows support in 0.8 is known to be
> > > broken (as opposed to "not known to be broken but not known to be
> working
> > > either" since we are not doing aggressive system testing on windows).
> > >
> > > I would feel more comfortable doing the patch on 0.8 if there was
> someone
> > > who would be willing to take on real load testing and/or production
> > > operation on Windows so we could have some confidence that Kafka on
> > Windows
> > > actually works, otherwise this could just be the tip of the iceberg.
> > >
> > > Also it would be great to get review on that patch regardless of the
> > > destination.
> > >
> > > -Jay
> > >
> >
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Btw, I've been running this patch in our cloud env and it's been working
fine so far.
I actually filed another bug as I saw another problem on windows locally (
https://issues.apache.org/jira/browse/KAFKA-1036).
Tim
On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <ja...@gmail.com> wrote:
> That would be great!
>
> -Jay
>
>
> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
>
> > Hi Jay,
> >
> > I'm planning to test run Kafka on Windows in our test environments
> > evaluating if it's suitable for production usage.
> >
> > I can provide feedback with the patch how well it works and if we
> encounter
> > any functional or perf problems.
> >
> > Tim
> >
> >
> >
> >
> > On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
> >
> > > Elizabeth and I have a patch to support our memory mapped offset index
> > > files properly on Windows:
> > > https://issues.apache.org/jira/browse/KAFKA-1008
> > >
> > > Question: Do we want this on 0.8 or trunk? I would feel more
> comfortable
> > > with it in trunk, but that means windows support in 0.8 is known to be
> > > broken (as opposed to "not known to be broken but not known to be
> working
> > > either" since we are not doing aggressive system testing on windows).
> > >
> > > I would feel more comfortable doing the patch on 0.8 if there was
> someone
> > > who would be willing to take on real load testing and/or production
> > > operation on Windows so we could have some confidence that Kafka on
> > Windows
> > > actually works, otherwise this could just be the tip of the iceberg.
> > >
> > > Also it would be great to get review on that patch regardless of the
> > > destination.
> > >
> > > -Jay
> > >
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
That would be great!
-Jay
On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
> Hi Jay,
>
> I'm planning to test run Kafka on Windows in our test environments
> evaluating if it's suitable for production usage.
>
> I can provide feedback with the patch how well it works and if we encounter
> any functional or perf problems.
>
> Tim
>
>
>
>
> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
>
> > Elizabeth and I have a patch to support our memory mapped offset index
> > files properly on Windows:
> > https://issues.apache.org/jira/browse/KAFKA-1008
> >
> > Question: Do we want this on 0.8 or trunk? I would feel more comfortable
> > with it in trunk, but that means windows support in 0.8 is known to be
> > broken (as opposed to "not known to be broken but not known to be working
> > either" since we are not doing aggressive system testing on windows).
> >
> > I would feel more comfortable doing the patch on 0.8 if there was someone
> > who would be willing to take on real load testing and/or production
> > operation on Windows so we could have some confidence that Kafka on
> Windows
> > actually works, otherwise this could just be the tip of the iceberg.
> >
> > Also it would be great to get review on that patch regardless of the
> > destination.
> >
> > -Jay
> >
>
Re: Patch for mmap + windows
Posted by Jay Kreps <ja...@gmail.com>.
That would be great!
-Jay
On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <tn...@gmail.com> wrote:
> Hi Jay,
>
> I'm planning to test run Kafka on Windows in our test environments
> evaluating if it's suitable for production usage.
>
> I can provide feedback with the patch how well it works and if we encounter
> any functional or perf problems.
>
> Tim
>
>
>
>
> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
>
> > Elizabeth and I have a patch to support our memory mapped offset index
> > files properly on Windows:
> > https://issues.apache.org/jira/browse/KAFKA-1008
> >
> > Question: Do we want this on 0.8 or trunk? I would feel more comfortable
> > with it in trunk, but that means windows support in 0.8 is known to be
> > broken (as opposed to "not known to be broken but not known to be working
> > either" since we are not doing aggressive system testing on windows).
> >
> > I would feel more comfortable doing the patch on 0.8 if there was someone
> > who would be willing to take on real load testing and/or production
> > operation on Windows so we could have some confidence that Kafka on
> Windows
> > actually works, otherwise this could just be the tip of the iceberg.
> >
> > Also it would be great to get review on that patch regardless of the
> > destination.
> >
> > -Jay
> >
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Hi Jay,
I'm planning to test run Kafka on Windows in our test environments
evaluating if it's suitable for production usage.
I can provide feedback with the patch how well it works and if we encounter
any functional or perf problems.
Tim
On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
> Elizabeth and I have a patch to support our memory mapped offset index
> files properly on Windows:
> https://issues.apache.org/jira/browse/KAFKA-1008
>
> Question: Do we want this on 0.8 or trunk? I would feel more comfortable
> with it in trunk, but that means windows support in 0.8 is known to be
> broken (as opposed to "not known to be broken but not known to be working
> either" since we are not doing aggressive system testing on windows).
>
> I would feel more comfortable doing the patch on 0.8 if there was someone
> who would be willing to take on real load testing and/or production
> operation on Windows so we could have some confidence that Kafka on Windows
> actually works, otherwise this could just be the tip of the iceberg.
>
> Also it would be great to get review on that patch regardless of the
> destination.
>
> -Jay
>
Re: Patch for mmap + windows
Posted by Timothy Chen <tn...@gmail.com>.
Hi Jay,
I'm planning to test run Kafka on Windows in our test environments
evaluating if it's suitable for production usage.
I can provide feedback with the patch how well it works and if we encounter
any functional or perf problems.
Tim
On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <ja...@gmail.com> wrote:
> Elizabeth and I have a patch to support our memory mapped offset index
> files properly on Windows:
> https://issues.apache.org/jira/browse/KAFKA-1008
>
> Question: Do we want this on 0.8 or trunk? I would feel more comfortable
> with it in trunk, but that means windows support in 0.8 is known to be
> broken (as opposed to "not known to be broken but not known to be working
> either" since we are not doing aggressive system testing on windows).
>
> I would feel more comfortable doing the patch on 0.8 if there was someone
> who would be willing to take on real load testing and/or production
> operation on Windows so we could have some confidence that Kafka on Windows
> actually works, otherwise this could just be the tip of the iceberg.
>
> Also it would be great to get review on that patch regardless of the
> destination.
>
> -Jay
>