You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "moomman (via GitHub)" <gi...@apache.org> on 2023/03/09 02:57:45 UTC
[GitHub] [shardingsphere-on-cloud] moomman opened a new pull request, #252: Issue 241
moomman opened a new pull request, #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252
add JVM_TOOL_OPTIONS and value agent config to enable metrics in proxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #252: Update Helm charts of ShardingSphere Proxy to support metrics agent
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] moomman commented on pull request #252: Issue 241
Posted by "moomman (via GitHub)" <gi...@apache.org>.
moomman commented on PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252#issuecomment-1461494374
i have check the code,thank for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on pull request #252: Issue 241
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252#issuecomment-1461349388
related to https://github.com/apache/shardingsphere-on-cloud/issues/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on a diff in pull request #252: Issue 241
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore commented on code in PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252#discussion_r1130583036
##########
charts/apache-shardingsphere-proxy-charts/templates/deployment.yaml:
##########
@@ -49,6 +49,16 @@ spec:
- name: mysql-connect-jar
mountPath: /opt/shardingsphere-proxy/ext-lib
{{- end }}
+ {{- if .Values.compute.agent.enabled }}
+ - name: agent-metrics-jar
+ image: busybox:1.35.0
+ command: ["sh","-c","wget https://mirrors.aliyun.com/apache/shardingsphere/{{ .Values.compute.image.tag | default .Chart.AppVersion }}/apache-shardingsphere-{{ .Values.compute.image.tag | default .Chart.AppVersion }}-shardingsphere-agent-bin.tar.gz;
Review Comment:
Please using Apache official site.
##########
charts/apache-shardingsphere-proxy-charts/templates/configmap.yaml:
##########
@@ -53,3 +53,16 @@ data:
</root>
</configuration>
+
+
+
+{{- if .Values.compute.agent.enabled}}
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: add-metrics
+data:
+ replace-agent.yaml: |-
Review Comment:
Consider change the key from `replace-agent.yaml` to `agent.yaml`
##########
charts/apache-shardingsphere-proxy-charts/templates/deployment.yaml:
##########
@@ -92,3 +113,13 @@ spec:
- name: mysql-connect-jar
emptyDir: { }
{{- end}}
+ {{- if .Values.compute.agent.enabled}}
+ - name: metrics-jar
+ emptyDir: { }
+ - name: agent-config
+ configMap:
+ name: add-metrics
+ items:
+ - key: replace-agent.yaml
Review Comment:
Please update the key from `replace-agent.yaml` to `agent.yaml` if changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on pull request #252: Issue 241
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore commented on PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252#issuecomment-1461473239
And also please change the issue title to a short description of this work. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on pull request #252: Update Helm charts of ShardingSphere Proxy to support metrics agent
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore commented on PR #252:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/252#issuecomment-1461528776
Please update the readme https://github.com/apache/shardingsphere-on-cloud/blob/main/charts/apache-shardingsphere-proxy-charts/README.md with this configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org