You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/19 17:09:22 UTC

[GitHub] gengliangwang opened a new pull request #23352: [SPARK-26409][SQL][TESTS] SQLConf should be serializable in test sessions

gengliangwang opened a new pull request #23352: [SPARK-26409][SQL][TESTS] SQLConf should be serializable in test sessions
URL: https://github.com/apache/spark/pull/23352
 
 
   ## What changes were proposed in this pull request?
   
   Currently the `SQLConf` in `WithTestConf` is not serializable. It uses the method `overrideConfs` in closure, while the class `TestHiveSessionStateBuilder` and `TestSQLSessionStateBuilder` are not serializable.
   
   This PR is to use a local variable to fix it.
   
   ## How was this patch tested?
   
   Add unit test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org