You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/22 21:12:12 UTC
[GitHub] [beam] damondouglas opened a new pull request, #22817: Implement KafkaSchemaTransformWriteConfiguration
damondouglas opened a new pull request, #22817:
URL: https://github.com/apache/beam/pull/22817
This PR addresses #21414 with a KafkaSchemaTransformWriteConfiguration implementation. It's design goals are to work with a KafkaSchemaTransformWriteProvider that extends a [TypedSchemaTransformProvider](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/TypedSchemaTransformProvider.java).
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- ~Update `CHANGES.md` with noteworthy changes.~
- ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1223060603
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1235740767
sorry Damon that I had been slow with this. Just one comment:
- Should users be able to specify whether they want to serialize their data into Avro / JSON / something else?
- We will have a PCollection<Row> as input, right? - how will users decide which is the key for the messages produced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1223058338
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas closed pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
damondouglas closed pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
URL: https://github.com/apache/beam/pull/22817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1223203861
@pabloem the only check that failed was Python_PVR_Flink `¯\_(ツ)_/¯`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #22817: Implement KafkaSchemaTransformWriteConfiguration
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #22817:
URL: https://github.com/apache/beam/pull/22817#issuecomment-1235789913
> * Should users be able to specify whether they want to serialize their data into Avro / JSON / something else?
Would the `getValueSerializer` inform the SchemaTransform whether it is Avro / Json or something else?
> * We will have a PCollection as input, right? - how will users decide which is the key for the messages produced?
Would the `getKeySerializer` inform the SchemaTransform how to write the Key data?
If both are true, then I wonder if we need to remove the `@Nullable` annotation from `getValueSerializer` and `getKeySerializer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org