You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Created) (JIRA)" <ji...@apache.org> on 2011/10/05 11:53:34 UTC
[jira] [Created] (QPID-3519) the 0-10 client does not send the
selector argument during subscription creation
the 0-10 client does not send the selector argument during subscription creation
--------------------------------------------------------------------------------
Key: QPID-3519
URL: https://issues.apache.org/jira/browse/QPID-3519
Project: Qpid
Issue Type: Bug
Components: Java Client
Reporter: Robbie Gemmell
Fix For: 0.13
It appears that the client only sends the selector argument when binding queues during consumer creation, meaning only the topic exchange will do any server-side selector filtering (the other exchanges dont have such functionality). The subscription based selector argument is not sent, meaning the behaviour when using queues not bound to the topic exchange with regular consumers will result in the 0-10 client receiving all messages and then having to release and not acquire the ones it doesnt want (relating to QPID-2848, where it is seen such functionality is currently broken). The client should send the selector argument at subscription time also, to prevent it being sent messages it doesnt want by brokers which support server-side selectors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Status: Ready To Review (was: In Progress)
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.14
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Attachment: 0001-QPID-3519-refactor-consumer-argument-handling.patch
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.14
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Attachment: (was: 0001-QPID-3519-refactor-consumer-argument-handling.patch)
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.14
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3519) the 0-10 client does not send the
selector argument during subscription creation
Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3519:
--------------------------------
Assignee: Alex Rudyy
> the 0-10 client does not send the selector argument during subscription creation
> --------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.13
>
>
> It appears that the client only sends the selector argument when binding queues during consumer creation, meaning only the topic exchange will do any server-side selector filtering (the other exchanges dont have such functionality). The subscription based selector argument is not sent, meaning the behaviour when using queues not bound to the topic exchange with regular consumers will result in the 0-10 client receiving all messages and then having to release and not acquire the ones it doesnt want (relating to QPID-2848, where it is seen such functionality is currently broken). The client should send the selector argument at subscription time also, to prevent it being sent messages it doesnt want by brokers which support server-side selectors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3519:
-----------------------------
Fix Version/s: (was: 0.14)
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Description:
In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
This needs to be improved to allow both clients to reuse the same code.
was:It appears that the client only sends the selector argument when binding queues during consumer creation, meaning only the topic exchange will do any server-side selector filtering (the other exchanges dont have such functionality). The subscription based selector argument is not sent, meaning the behaviour when using queues not bound to the topic exchange with regular consumers will result in the 0-10 client receiving all messages and then having to release and not acquire the ones it doesnt want (relating to QPID-2848, where it is seen such functionality is currently broken). The client should send the selector argument at subscription time also, to prevent it being sent messages it doesnt want by brokers which support server-side selectors.
Fix Version/s: (was: 0.13)
0.14
Summary: Refactor the logic behind sending of the selector arguments during subscription creation (was: the 0-10 client does not send the selector argument during subscription creation)
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.14
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3519.
------------------------------
Resolution: Fixed
No comments, patch applied.
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) the 0-10 client does not send the
selector argument during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Attachment: 0001-QPID-3519-refactor-consumer-argument-handling.patch
Attached a patch refactoring consumer argument handling
> the 0-10 client does not send the selector argument during subscription creation
> --------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> It appears that the client only sends the selector argument when binding queues during consumer creation, meaning only the topic exchange will do any server-side selector filtering (the other exchanges dont have such functionality). The subscription based selector argument is not sent, meaning the behaviour when using queues not bound to the topic exchange with regular consumers will result in the 0-10 client receiving all messages and then having to release and not acquire the ones it doesnt want (relating to QPID-2848, where it is seen such functionality is currently broken). The client should send the selector argument at subscription time also, to prevent it being sent messages it doesnt want by brokers which support server-side selectors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] [Assigned] (QPID-3519) Refactor the logic behind sending
of the selector arguments during subscription creation
Posted by Keith W <ke...@gmail.com>.
Hi Justin
It is intended for trunk, sorry for the confusion. I've just updated
the Jira to show 0-15.
cheers Keith.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] [Assigned] (QPID-3519) Refactor the logic behind sending
of the selector arguments during subscription creation
Posted by Justin Ross <jr...@redhat.com>.
Okay, sorry. I should have considered that explanation.
Alex, it's intended for trunk and not the release branch, true?
Justin
On Mon, 7 Nov 2011, Robbie Gemmell wrote:
> I think the version tag on JIRA is just left over from when the issue
> was originally created by me a month or so ago, but it has been
> modified since then by Alex to reflect new info as he and Keith worked
> on it and probably just not had the version updated. I'm not sure
> there is actually any intention of putting that into the release
> branch.
>
> Robbie
>
> On 7 November 2011 18:32, Justin Ross <jr...@redhat.com> wrote:
>> I have a question about this one. It's called a refactoring, the patch is
>> somwhat larger than a simple bug fix would typically call for, and it
>> doesn't seem to address any regression. Should it go to 0.16 instead?
>>
>> I don't intend to block the request. I'd like there to be a discussion,
>> however.
>>
>> Justin
>>
>> On Mon, 7 Nov 2011, Alex Rudyy (Assigned) (JIRA) wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Alex Rudyy reassigned QPID-3519:
>>> --------------------------------
>>>
>>> Assignee: Keith Wall (was: Alex Rudyy)
>>>
>>> Keith,
>>> could you please review and commit attached patch?
>>>
>>>> Refactor the logic behind sending of the selector arguments during
>>>> subscription creation
>>>>
>>>> ----------------------------------------------------------------------------------------
>>>>
>>>> Key: QPID-3519
>>>> URL: https://issues.apache.org/jira/browse/QPID-3519
>>>> Project: Qpid
>>>> Issue Type: Bug
>>>> Components: Java Client
>>>> Reporter: Robbie Gemmell
>>>> Assignee: Keith Wall
>>>> Fix For: 0.14
>>>>
>>>> Attachments:
>>>> 0001-QPID-3519-refactor-consumer-argument-handling.patch
>>>>
>>>>
>>>> In current implementation the FieldTable with JMS selector is created in
>>>> AMQSession#createConsumerImpl.
>>>> The 0-8 MessageConsumer code creates a new FieldTable objects when
>>>> sending its BasicConsime method.
>>>> The 0-10 AMQSession code does send an arguments map sourced from the
>>>> consumer when doing the 'sendConsume' method.
>>>> Also, both clients send FieldTable with the selector argument they do it
>>>> using different FieldTable objects.
>>>> This needs to be improved to allow both clients to reuse the same code.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA
>>> administrators:
>>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project: http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
Re: [jira] [Assigned] (QPID-3519) Refactor the logic behind sending
of the selector arguments during subscription creation
Posted by Robbie Gemmell <ro...@gmail.com>.
I think the version tag on JIRA is just left over from when the issue
was originally created by me a month or so ago, but it has been
modified since then by Alex to reflect new info as he and Keith worked
on it and probably just not had the version updated. I'm not sure
there is actually any intention of putting that into the release
branch.
Robbie
On 7 November 2011 18:32, Justin Ross <jr...@redhat.com> wrote:
> I have a question about this one. It's called a refactoring, the patch is
> somwhat larger than a simple bug fix would typically call for, and it
> doesn't seem to address any regression. Should it go to 0.16 instead?
>
> I don't intend to block the request. I'd like there to be a discussion,
> however.
>
> Justin
>
> On Mon, 7 Nov 2011, Alex Rudyy (Assigned) (JIRA) wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Alex Rudyy reassigned QPID-3519:
>> --------------------------------
>>
>> Assignee: Keith Wall (was: Alex Rudyy)
>>
>> Keith,
>> could you please review and commit attached patch?
>>
>>> Refactor the logic behind sending of the selector arguments during
>>> subscription creation
>>>
>>> ----------------------------------------------------------------------------------------
>>>
>>> Key: QPID-3519
>>> URL: https://issues.apache.org/jira/browse/QPID-3519
>>> Project: Qpid
>>> Issue Type: Bug
>>> Components: Java Client
>>> Reporter: Robbie Gemmell
>>> Assignee: Keith Wall
>>> Fix For: 0.14
>>>
>>> Attachments:
>>> 0001-QPID-3519-refactor-consumer-argument-handling.patch
>>>
>>>
>>> In current implementation the FieldTable with JMS selector is created in
>>> AMQSession#createConsumerImpl.
>>> The 0-8 MessageConsumer code creates a new FieldTable objects when
>>> sending its BasicConsime method.
>>> The 0-10 AMQSession code does send an arguments map sourced from the
>>> consumer when doing the 'sendConsume' method.
>>> Also, both clients send FieldTable with the selector argument they do it
>>> using different FieldTable objects.
>>> This needs to be improved to allow both clients to reuse the same code.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] [Assigned] (QPID-3519) Refactor the logic behind sending
of the selector arguments during subscription creation
Posted by Justin Ross <jr...@redhat.com>.
I have a question about this one. It's called a refactoring, the
patch is somwhat larger than a simple bug fix would typically call for,
and it doesn't seem to address any regression. Should it go to 0.16
instead?
I don't intend to block the request. I'd like there to be a discussion,
however.
Justin
On Mon, 7 Nov 2011, Alex Rudyy (Assigned) (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Alex Rudyy reassigned QPID-3519:
> --------------------------------
>
> Assignee: Keith Wall (was: Alex Rudyy)
>
> Keith,
> could you please review and commit attached patch?
>
>> Refactor the logic behind sending of the selector arguments during subscription creation
>> ----------------------------------------------------------------------------------------
>>
>> Key: QPID-3519
>> URL: https://issues.apache.org/jira/browse/QPID-3519
>> Project: Qpid
>> Issue Type: Bug
>> Components: Java Client
>> Reporter: Robbie Gemmell
>> Assignee: Keith Wall
>> Fix For: 0.14
>>
>> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>>
>>
>> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
>> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
>> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
>> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
>> This needs to be improved to allow both clients to reuse the same code.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3519:
--------------------------------
Assignee: Keith Wall (was: Alex Rudyy)
Keith,
could you please review and commit attached patch?
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.14
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3519) Refactor the logic behind sending of
the selector arguments during subscription creation
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3519:
-----------------------------
Fix Version/s: 0.15
> Refactor the logic behind sending of the selector arguments during subscription creation
> ----------------------------------------------------------------------------------------
>
> Key: QPID-3519
> URL: https://issues.apache.org/jira/browse/QPID-3519
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
> Attachments: 0001-QPID-3519-refactor-consumer-argument-handling.patch
>
>
> In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.
> The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.
> The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.
> Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.
> This needs to be improved to allow both clients to reuse the same code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org