[jira] [Commented] (BEAM-2714) ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.

["Pei He (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112072#comment-16112072 ] 

Pei He commented on BEAM-2714:
------------------------------

Just to clarify: with runner API, there will be no view transform (neither primitive or composite), and runners need to look at ViewFn in ParDo payload to determine whether the input PCollections need to be materialized.

Is that right?

> ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2714
>                 URL: https://issues.apache.org/jira/browse/BEAM-2714
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Thomas Groh
>            Priority: Critical
>             Fix For: Not applicable
>
>         Attachments: view-tag.png
>
>
> For example, input-pc -> View.AsIterable -> view.out -> ParDo
> getInputs() in TransformHierarchy.Node for ParDo will return input-pc instead of view.out.
> I think the code here should make sure the output of view is returned:
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionViews.java#L147



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)