[GitHub] [apisix] dmsolr opened a new pull request #4180: fix: fix peer missed in skywalking

[GitBox <gi...@apache.org>]

dmsolr opened a new pull request #4180:
URL: https://github.com/apache/apisix/pull/4180


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   So far, `peer` of the exit span is a hard code, "upstream service". This is PR intends to fix it by getting `ip:port` from dynamic balancer.
   
   I tried to get the information at the `rewrite` phase, but it seems like cannot get it. Because of that, I move it into the `body_filter` phase.
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] dmsolr closed pull request #4180: fix: fix peer missed in skywalking

[GitBox <gi...@apache.org>]

dmsolr closed pull request #4180:
URL: https://github.com/apache/apisix/pull/4180


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] dmsolr commented on pull request #4180: fix: fix peer missed in skywalking

[GitBox <gi...@apache.org>]

dmsolr commented on pull request #4180:
URL: https://github.com/apache/apisix/pull/4180#issuecomment-851591608


   This PR is not ready, and I need to take much time to resolve how to get the exactly upstream in rewrite phase. For this reason, I close it before I get the way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org