You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by ChinmaySKulkarni <gi...@git.apache.org> on 2018/03/22 20:19:21 UTC
[GitHub] phoenix pull request #296: PHOENIX-4668: Remove unnecessary table descriptor...
GitHub user ChinmaySKulkarni opened a pull request:
https://github.com/apache/phoenix/pull/296
PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column
Removed the code which: removed the SPLIT_POLICY in the system catalog
table descriptor and then added it and modified the table.
This was earlier done as a workaround for HBASE-12570.
We specifically add the SPLIT_POLICY when creating system tables already
as part of the patch for PHOENIX-1674, hence this is no longer required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-4668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 55df92b9df24e7ae6999f78aef5274c03e052e27
Author: Chinmay Kulkarni <ch...@...>
Date: 2018-03-22T20:14:10Z
PHOENIX-4668: Remove unnecessary table descriptor modification for SPLIT_POLICY column
Removed the code which: removed the SPLIT_POLICY in the system catalog
table descriptor and then added it and modified the table.
This was earlier done as a workaround for HBASE-12570.
We specifically add the SPLIT_POLICY when creating system tables already
as part of the patch for PHOENIX-1674, hence this is no longer required.
----
---
[GitHub] phoenix issue #296: PHOENIX-4668: Remove unnecessary table descriptor modifi...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on the issue:
https://github.com/apache/phoenix/pull/296
@twdsilva @JamesRTaylor please review. Thanks.
---
[GitHub] phoenix issue #296: PHOENIX-4668: Remove unnecessary table descriptor modifi...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/296
+1. Will commit soon.
---
[GitHub] phoenix issue #296: PHOENIX-4668: Remove unnecessary table descriptor modifi...
Posted by twdsilva <gi...@git.apache.org>.
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/296
+1
---
[GitHub] phoenix issue #296: PHOENIX-4668: Remove unnecessary table descriptor modifi...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on the issue:
https://github.com/apache/phoenix/pull/296
@JamesRTaylor please review. Thanks!
---
[GitHub] phoenix pull request #296: PHOENIX-4668: Remove unnecessary table descriptor...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni closed the pull request at:
https://github.com/apache/phoenix/pull/296
---