You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/12/24 23:14:18 UTC

[GitHub] incubator-zeppelin pull request: Fix z-index of control button too...

GitHub user minahlee opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/570

    Fix z-index of control button tooltip

    ### What is this PR for?
    Fix z-index for control button tooltip
    
    ### What type of PR is it?
    Bug Fix
    
    ### Is there a relevant Jira issue?
    No
    
    ### Screenshots (if appropriate)
    **Default mode**
    Before
    <img width="1139" alt="screen shot 2015-12-24 at 1 53 50 pm" src="https://cloud.githubusercontent.com/assets/8503346/11998137/d93b2f44-aa45-11e5-84ca-21860774cc7d.png">
    
    After
    <img width="1139" alt="screen shot 2015-12-24 at 1 53 36 pm" src="https://cloud.githubusercontent.com/assets/8503346/11998135/cf42b85e-aa45-11e5-94b2-4ec577971957.png">
    
    **Simple mode**
    Before
    <img width="1139" alt="screen shot 2015-12-24 at 1 55 25 pm" src="https://cloud.githubusercontent.com/assets/8503346/11998143/20e3ec50-aa46-11e5-98f7-dcc6d14a8acc.png">
    
    After
    <img width="1139" alt="screen shot 2015-12-24 at 1 55 17 pm" src="https://cloud.githubusercontent.com/assets/8503346/11998145/277b3cda-aa46-11e5-8d44-89d25d09b373.png">
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/incubator-zeppelin fix/tooltip_zindex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #570
    
----
commit 01579537ca11f3b4e240a0bfa6f344a40ebfeeec
Author: Mina Lee <mi...@nflabs.com>
Date:   2015-12-24T21:37:10Z

    Fix z-index of control button tooltip

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix z-index of control button too...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/570#issuecomment-167241555
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix z-index of control button too...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/570#issuecomment-167178119
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix z-index of control button too...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/570


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---