Re: [PR] Clarify the atomicity of BasePersistence methods [polaris]

["eric-maynard (via GitHub)" <gi...@apache.org>]

eric-maynard commented on code in PR #1274:
URL: https://github.com/apache/polaris/pull/1274#discussion_r2021947904


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -37,6 +37,11 @@
  * defining the internal data model for Polaris, and which defines the basis for the RBAC model
  * provided by Polaris.
  *
+ * <p>Each method in this interface must be atomic, meaning that write operations must either fully
+ * succeed with all changes applied, or fail entirely without any side effects or partial updates.
+ * Read operations must return a consistent view of the data as it existed at a specific point in

Review Comment:
   +1, if we have such a strong requirement then I think we should be clear about what that point in time is.
   
   Also, what is a "read operation"? How does that interact with pagination?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org