You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/02/17 05:24:16 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2983: FINERACT-1707: Transaction Summary Report changes
josehernandezfintecheandomx opened a new pull request, #2983:
URL: https://github.com/apache/fineract/pull/2983
## Description
Transaction Summary report updated with the following changes
- To have Transaction subtype column ( this is payment types in fineract)
- To have Accural transaction split based on the charge types)
- Payment type_name = which is nothing but the transaction subtype of the repayments, chargebacks, and any transaction type which is using the payment type dropdown.
- Charge type = This displays the split of accrual transactions between the types of charges
[FINERACT-1707](https://issues.apache.org/jira/browse/FINERACT-1707)
<img width="1351" alt="Screenshot 2023-02-16 at 23 19 07" src="https://user-images.githubusercontent.com/44206706/219556373-647335ae-1d02-4271-84ee-c8fa351a9990.png">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2983:
URL: https://github.com/apache/fineract/pull/2983#issuecomment-1434743506
@josehernandezfintecheandomx Kindly fix the conflict and please help me check whether this report is working with mysql and postgres as well? (should we have a test which calls it and check some outcome maybe?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "bharathcgowda (via GitHub)" <gi...@apache.org>.
bharathcgowda commented on PR #2983:
URL: https://github.com/apache/fineract/pull/2983#issuecomment-1439801068
@adamsaghy could you please review again and merge please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2983:
URL: https://github.com/apache/fineract/pull/2983#issuecomment-1439803461
> @adamsaghy could you please review again and merge please?
I am still waiting on @josehernandezfintecheandomx reply on my questions...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "bharathcgowda (via GitHub)" <gi...@apache.org>.
bharathcgowda commented on PR #2983:
URL: https://github.com/apache/fineract/pull/2983#issuecomment-1434539253
@adamsaghy @alexivanov could any one of you please help in reviewing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #2983:
URL: https://github.com/apache/fineract/pull/2983#discussion_r1109907443
##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0092_update_general_accounting_table_reports.xml:
##########
@@ -0,0 +1,195 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">
+ <!-- Transaction Summary report -->
+ <changeSet author="fineract" id="3">
+ <update tableName="stretchy_report">
+ <column name="report_sql" value="SELECT
Review Comment:
is this working with mysql and postgres as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "bharathcgowda (via GitHub)" <gi...@apache.org>.
bharathcgowda commented on PR #2983:
URL: https://github.com/apache/fineract/pull/2983#issuecomment-1439972284
@adamsaghy the script works both on mysql and postgres.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #2983: FINERACT-1707: Transaction Summary Report changes
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #2983:
URL: https://github.com/apache/fineract/pull/2983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org