You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "puchengy (via GitHub)" <gi...@apache.org> on 2025/03/12 06:47:17 UTC

[I] IRC does not support creating V1 table via snapshot procedure (stage create) [iceberg]

puchengy opened a new issue, #12500:
URL: https://github.com/apache/iceberg/issues/12500

   ### Apache Iceberg version
   
   1.5.2
   
   ### Query engine
   
   Spark
   
   ### Please describe the bug 🐞
   
   `CatalogHandlers` (used by Rest Catalog) when executing `updateTable` with transaction [code](https://github.com/apache/iceberg/blob/1.5.x/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java#L292) will always create an empty builder of default table version 2 (in Iceberg 1.5.2). This does not work if user intentionally want to create v1 table only, as a result, query like 
   ```
   CALL spark_catalog.system.snapshot(..., map('format-version', '1');
   ```
   will fail with `Cannot downgrade v2 table to v1` error.
   
   A propose fix is when calling [TableMetadata.buildFromEmpty()](https://github.com/apache/iceberg/blob/1.5.x/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java#L336) we honor the format version if the request already set it.
   
   ### Willingness to contribute
   
   - [ ] I can contribute a fix for this bug independently
   - [x] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
   - [ ] I cannot contribute a fix for this bug at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] IRC does not support creating V1 table via snapshot procedure (stage create) [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on issue #12500:
URL: https://github.com/apache/iceberg/issues/12500#issuecomment-2720039171

   @puchengy can we close this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] IRC does not support creating V1 table via snapshot procedure (stage create) [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on issue #12500:
URL: https://github.com/apache/iceberg/issues/12500#issuecomment-2717065567

   I believe this was fixed by https://github.com/apache/iceberg/commit/24d26b6a35a1287531e72357691d9dbd3d7f79bd


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] IRC does not support creating V1 table via snapshot procedure (stage create) [iceberg]

Posted by "puchengy (via GitHub)" <gi...@apache.org>.
puchengy commented on issue #12500:
URL: https://github.com/apache/iceberg/issues/12500#issuecomment-2720114245

   @nastra yes, sorry about that, I confirmed backport fixed it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] IRC does not support creating V1 table via snapshot procedure (stage create) [iceberg]

Posted by "puchengy (via GitHub)" <gi...@apache.org>.
puchengy closed issue #12500: IRC does not support creating V1 table via snapshot procedure (stage create)
URL: https://github.com/apache/iceberg/issues/12500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org