You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2017/09/05 19:13:05 UTC
kudu git commit: kudu-tool-test: find path to false at runtime
Repository: kudu
Updated Branches:
refs/heads/master ba3cceea6 -> 5583d6200
kudu-tool-test: find path to false at runtime
On macos the false binary is in /usr/bin/false.
Change-Id: I2e2cd346b48c61cfe27fc77ee3cabb681be94ab2
Reviewed-on: http://gerrit.cloudera.org:8080/7959
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/5583d620
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/5583d620
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/5583d620
Branch: refs/heads/master
Commit: 5583d620002a2b13a5ed8b8f90dc1dd1355ca174
Parents: ba3ccee
Author: Dan Burkert <da...@apache.org>
Authored: Tue Sep 5 11:49:37 2017 -0700
Committer: Dan Burkert <da...@apache.org>
Committed: Tue Sep 5 19:12:34 2017 +0000
----------------------------------------------------------------------
src/kudu/tools/kudu-tool-test.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/5583d620/src/kudu/tools/kudu-tool-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tools/kudu-tool-test.cc b/src/kudu/tools/kudu-tool-test.cc
index ce5f016..b4171b0 100644
--- a/src/kudu/tools/kudu-tool-test.cc
+++ b/src/kudu/tools/kudu-tool-test.cc
@@ -775,7 +775,9 @@ TEST_F(ToolTest, TestPbcTools) {
// Test 'edit' with an unsuccessful edit.
{
string stdout, stderr;
- Status s = DoEdit("/bin/false", &stdout, &stderr);
+ string path;
+ ASSERT_OK(GetExecutablePath("false", {}, &path));
+ Status s = DoEdit(path, &stdout, &stderr);
ASSERT_FALSE(s.ok());
ASSERT_EQ("", stdout);
ASSERT_EQ("Aborted: editor returned non-zero exit code", stderr);