You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kevinyu98 <gi...@git.apache.org> on 2018/08/14 07:06:10 UTC
[GitHub] spark pull request #22100: [PySpark] [SQL]include PandasUDFType in the impor...
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/22100
[PySpark] [SQL]include PandasUDFType in the import all of pyspark.sql.functions
## What changes were proposed in this pull request?
include pyspark.sql.functions in the import all of pyspark.sql.functions
## How was this patch tested?
Run the test case from the pyspark shell from the jira [spark-25105](https://jira.apache.org/jira/browse/SPARK-25105?jql=project%20%3D%20SPARK%20AND%20component%20in%20(ML%2C%20PySpark%2C%20SQL%2C%20%22Structured%20Streaming%22))
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinyu98/spark spark-25105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22100
----
commit 8201eafd6136d9a3998de7c1574b5aa20993c6c7
Author: Kevin Yu <qy...@...>
Date: 2018-08-14T07:01:07Z
include PandasUDFType in the import all
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94768/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94767/testReport)** for PR 22100 at commit [`06e41b5`](https://github.com/apache/spark/commit/06e41b5ff60b45a95eb8712e645d909d1456349d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22100
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by kevinyu98 <gi...@git.apache.org>.
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/22100
@HyukjinKwon @dilipbiswal Thanks for your comments, I have changed the code. I removed the code changes in tests.py, because it got warning message during style checking, and I did manually testing and add the result in the pr description.
`Qianyangs-MBP:spark qianyangyu$ ./dev/lint-python
./python/pyspark/sql/tests.py:4357: SyntaxWarning: import * only allowed at module level
@unittest.skipIf(
pycodestyle checks passed.
rm -rf _build/*
pydoc checks passed.`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22100
Mind linking the JIRA by fixing the title like `[SPARK-25105][PYTHON] Include ...`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94767/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94735/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by kevinyu98 <gi...@git.apache.org>.
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/22100
@holdenk Hello Holden: Can you check the code changes? Is this what you expected behavior? Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType...
Posted by kevinyu98 <gi...@git.apache.org>.
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22100#discussion_r210091625
--- Diff: python/pyspark/sql/functions.py ---
@@ -2927,7 +2927,7 @@ def pandas_udf(f=None, returnType=None, functionType=None):
__all__ = [k for k, v in globals().items()
if not k.startswith('_') and k[0].islower() and callable(v) and k not in blacklist]
__all__.sort()
-
+__all__ += ["PandasUDFType"]
--- End diff --
yah, let me change it. Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94735/testReport)** for PR 22100 at commit [`8201eaf`](https://github.com/apache/spark/commit/8201eafd6136d9a3998de7c1574b5aa20993c6c7).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/22100
merged to master, thanks @kevinyu98 !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94767/testReport)** for PR 22100 at commit [`06e41b5`](https://github.com/apache/spark/commit/06e41b5ff60b45a95eb8712e645d909d1456349d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22100
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94768/testReport)** for PR 22100 at commit [`4c67e07`](https://github.com/apache/spark/commit/4c67e07d64818c83652b9050d5dd120a10cbac69).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [PySpark] [SQL]include PandasUDFType in the import all o...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94735/testReport)** for PR 22100 at commit [`8201eaf`](https://github.com/apache/spark/commit/8201eafd6136d9a3998de7c1574b5aa20993c6c7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType...
Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22100#discussion_r210089160
--- Diff: python/pyspark/sql/functions.py ---
@@ -2927,7 +2927,7 @@ def pandas_udf(f=None, returnType=None, functionType=None):
__all__ = [k for k, v in globals().items()
if not k.startswith('_') and k[0].islower() and callable(v) and k not in blacklist]
__all__.sort()
-
+__all__ += ["PandasUDFType"]
--- End diff --
@kevinyu98 should this be before the sort() ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22100
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22100
@kevinyu98 Can you please fix the description to "IncludeInclude PandasUDFType in the import all of pyspark.sql.functions" or anything better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22100: [SPARK-25105][PySpark] [SQL]Include PandasUDFType in the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22100
**[Test build #94768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94768/testReport)** for PR 22100 at commit [`4c67e07`](https://github.com/apache/spark/commit/4c67e07d64818c83652b9050d5dd120a10cbac69).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org