You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2025/11/03 03:50:35 UTC
[PR] Add memory annotations and standardize function declarations (celix)
PengZheng opened a new pull request, #806:
URL: https://github.com/apache/celix/pull/806
### Description
This pull request focuses on improving code clarity and consistency. The changes include:
- Adding memory ownership annotations to improve code documentation and enable better static analysis.
- Standardizing function declarations by explicitly including `void` in parameter lists for consistency.
- Introducing the `CELIX_HAS_ATTRIBUTE` macro to check for attribute support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP]Memory Ownership Annotations (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on PR #806:
URL: https://github.com/apache/celix/pull/806#issuecomment-5594321531
Just leave a note: I am still working on this, i.e. fixing the remaining limitation in LLVM upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add memory annotations and standardize function declarations (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #806:
URL: https://github.com/apache/celix/pull/806#issuecomment-3478823907
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/806?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 91.47%. Comparing base ([`6418698`](https://app.codecov.io/gh/apache/celix/commit/64186985722cc0a1c6ef107a5a71770ec19d303f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`245a3a2`](https://app.codecov.io/gh/apache/celix/commit/245a3a2d4f0210cff3c450bd7d2eff42c93963ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
- Coverage 91.52% 91.47% -0.06%
==========================================
Files 236 236
Lines 29561 28818 -743
==========================================
- Hits 27057 26361 -696
+ Misses 2504 2457 -47
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celix/pull/806?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP]Memory Ownership Annotations (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on PR #806:
URL: https://github.com/apache/celix/pull/806#issuecomment-3539714130
> Should we also add clang-tidy to our CI?
Yes.
> For the usage of '(void)' for an explicit empty argument list, maybe this should also be added to our coding conventions documentation.
>
> And ideally when to use 'CELIX_OWNERSHIP_RETURNS', '_TAKES' and ' _HOLDS' should also be documented.
I am currently working on fixing the `cleanup` attributes modeling issue, and will follow the above suggestions once it's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org