You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/07 21:55:51 UTC

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6696: Add E2E testing to TPv2

shamrickus commented on code in PR #6696:
URL: https://github.com/apache/trafficcontrol/pull/6696#discussion_r845589500


##########
.github/actions/tpv2-integration-tests/tpv2-integration-tests.ts:
##########
@@ -0,0 +1,31 @@
+/*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*     http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+"use strict";
+import child_process, { SpawnSyncOptions, SpawnSyncReturns } from "child_process";

Review Comment:
   This is literally the same file that all integration tests use, honestly not even sure why we're using JS runners seems like it's way more code and we do nothing with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org