You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "hydraxman (via GitHub)" <gi...@apache.org> on 2026/08/28 23:07:52 UTC
[PR] fix(desktop): stop Runtime Host after launcher loss [maka]
hydraxman opened a new pull request, #4114:
URL: https://github.com/apache/maka/pull/4114
## Summary
Bind Desktop-spawned ephemeral Runtime Hosts to the Desktop launcher lifecycle. If the Electron main process exits abruptly, loss of the inherited IPC channel now closes the owned Host instead of leaving it to block a later launch. Generic detached Runtime Hosts keep their existing reusable lifetime.
Fixes #4111
## Verification
- RED on `2c066316`: `node --test --test-name-pattern="launcher-owned detached Host" packages/runtime-host/dist/__tests__/host-kernel.test.js` — failed because the Host connection stayed open after launcher exit.
- `npm --workspace @maka/runtime-host test` — 1,346 passed, 9 skipped.
- `npm --workspace @maka/desktop run build:main` — passed.
- `node --test apps/desktop/dist/main/__tests__/runtime-host-desktop-candidate.test.js apps/desktop/dist/main/__tests__/runtime-host-desktop-manager.test.js` — 54 passed.
- `npm run lint` — passed.
- `npm run format:check` — passed.
`npm --workspace @maka/desktop run build:workspace-deps` reached the unchanged `@maka/ui` workspace and failed on existing Astryx API type mismatches (`settledText`, `conversationKey`, `unlockAutoFollow`, and `trailingAction`); the affected Runtime Host and Desktop main-process builds above pass.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex assisted with implementation and regression-test drafting; I reviewed the design, diff, and verification.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): stop Runtime Host after launcher loss [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4114:
URL: https://github.com/apache/maka/pull/4114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): stop Runtime Host after launcher loss [maka]
Posted by "hydraxman (via GitHub)" <gi...@apache.org>.
hydraxman commented on PR #4114:
URL: https://github.com/apache/maka/pull/4114#issuecomment-5465347262
Automated follow-up by GitHub Copilot under @hydraxman’s contribution workflow:
The production barrier-path finding was valid. Commit `c945d992` now enables the launch-owner IPC guard for `launchOwnedRuntimeHostCandidate` when `closeOnLauncherExit` is set, and the regression fixture exercises that owned launcher instead of the detached helper.
RED on the prior head: the focused owned-launcher test timed out after 5 seconds with `launcher-owned detached Host survived its launcher`. GREEN on `c945d992`: the same test passed; the full `@maka/runtime-host` suite passed 1,346 tests with 9 skipped. Root lint (2,899 files), format (1,749 files), and `git diff --check` also passed. Please re-check the updated head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org