[shardingsphere] branch master updated: [Issue #20374]-Improving coverage of AlterViewStatementHandler (#20822)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new f650a215a3d [Issue #20374]-Improving coverage of AlterViewStatementHandler (#20822)
f650a215a3d is described below

commit f650a215a3d42ba7522fa69a318bc4d063d22581
Author: Abhinav Koppula <ab...@gmail.com>
AuthorDate: Tue Sep 6 16:16:42 2022 +0530

    [Issue #20374]-Improving coverage of AlterViewStatementHandler (#20822)
---
 .../handler/ddl/AlterViewStatementHandlerTest.java      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterViewStatementHandlerTest.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterViewStatementHandlerTest.java
index 74dcef39f37..82dea074bbb 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterViewStatementHandlerTest.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterViewStatementHandlerTest.java
@@ -24,7 +24,9 @@ import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.Identifi
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl.MySQLAlterViewStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dml.MySQLSelectStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussAlterViewStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleAlterViewStatement;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterViewStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerAlterViewStatement;
 import org.junit.Test;
 
 import java.util.Optional;
@@ -82,4 +84,19 @@ public final class AlterViewStatementHandlerTest {
         Optional<SimpleTableSegment> renameViewSegment = AlterViewStatementHandler.getRenameView(alterViewStatement);
         assertFalse(renameViewSegment.isPresent());
     }
+    
+    @Test
+    public void assertGetSelectStatementForOtherDatabases() {
+        assertFalse(AlterViewStatementHandler.getSelectStatement(new OpenGaussAlterViewStatement()).isPresent());
+        assertFalse(AlterViewStatementHandler.getSelectStatement(new OracleAlterViewStatement()).isPresent());
+        assertFalse(AlterViewStatementHandler.getSelectStatement(new PostgreSQLAlterViewStatement()).isPresent());
+        assertFalse(AlterViewStatementHandler.getSelectStatement(new SQLServerAlterViewStatement()).isPresent());
+    }
+    
+    @Test
+    public void assertGetRenameViewForOtherDatabases() {
+        assertFalse(AlterViewStatementHandler.getRenameView(new MySQLAlterViewStatement()).isPresent());
+        assertFalse(AlterViewStatementHandler.getRenameView(new OracleAlterViewStatement()).isPresent());
+        assertFalse(AlterViewStatementHandler.getRenameView(new SQLServerAlterViewStatement()).isPresent());
+    }
 }