[jira] [Commented] (KAFKA-5185) Adding the RecordMetadata that is returned by the producer to the commitRecord method for SourceTask

["Konstantine Karantasis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000088#comment-16000088 ] 

Konstantine Karantasis commented on KAFKA-5185:
-----------------------------------------------

Thank you [~GeoSmith] for the suggested improvement and the patch. FYI this is a change to a public facing Kafka Connect API, therefore to review and merge this patch it first has to be submitted, discussed and approved as a KIP. Here's a link describing how the Kafka Improvement Proposal (KIP) process works: [KIP process|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]

> Adding the RecordMetadata that is returned by the producer to the commitRecord method for SourceTask
> ----------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5185
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5185
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: George Smith
>             Fix For: 0.11.0.0
>
>
> An improvement request I thought would be useful.
> Added the producers record metadata object to the commitRecord method on the SourceTask class so more data is provided from the producer and it allows anyone overriding and hooking into the commitRecord method to receive more information about where the record was procuded to. 
> Left the old commitRecord method with just the sourcerecord for backwards compatbility even though this would technically be included in a new version of kafka, it would intoduce a breaking change without it. 
> Opened up PR here: https://github.com/apache/kafka/pull/2989



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)