You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/15 11:27:04 UTC
[GitHub] [superset] nraschi opened a new pull request, #19731: Fix: Chart does not cover the entire page with Standalone=1 #15252
nraschi opened a new pull request, #19731:
URL: https://github.com/apache/superset/pull/19731
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(chart explorer): charts cover the entire page when Standalone flag is set
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Added a check on the Standalone flag.
If the Standalone flag is set to true, then the chart dimensions are set to cover the entire page (without padding, used when in explore mode).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Load a chart with Standalone flag set to true
2. The chart must cover the entire page (without padding)
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #15252
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19731: Fix: Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1100088938
# [Codecov](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19731](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83b62e0) into [master](https://codecov.io/gh/apache/superset/commit/94075983f8abfcc7749cede5af9e24d2a9f1abe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9407598) will **decrease** coverage by `0.00%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 83b62e0 differs from pull request most recent head cd5400f. Consider uploading reports for the commit cd5400f to get more accurate results
```diff
@@ Coverage Diff @@
## master #19731 +/- ##
==========================================
- Coverage 66.51% 66.50% -0.01%
==========================================
Files 1686 1686
Lines 64591 64594 +3
Branches 6636 6637 +1
==========================================
Hits 42961 42961
- Misses 19931 19933 +2
- Partials 1699 1700 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.17% <25.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/19731/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `70.66% <25.00%> (-2.95%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9407598...cd5400f](https://codecov.io/gh/apache/superset/pull/19731?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
URL: https://github.com/apache/superset/pull/19731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1103509993
@nraschi there's a conflict in the PR, so you need to rebase it to master. If you can do that I can review it and get it merged if all is well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nraschi commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
nraschi commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1103982958
Hi @villebro, I managed to rebase my fork and review the conflict.
In this new version seem my contribution is not necessary anymore because the code that changes the chart dimension is not present.
I suppose the new version resolve #15252
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nraschi commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
nraschi commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1109600681
> Thanks @nraschi - so I assume we can close this PR?
Yep, as you've already done, thanks. This solution could be used in version 1.5.x, @villebro do you think is a good idea try to open a PR on that branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1108167274
Thanks @nraschi - so I assume we can close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1109576937
Closing as this appears to be redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nraschi commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
nraschi commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1102243637
Hi @villebro, I changed the pull request title, but the merging is blocked. Must I create a new pull request?
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nraschi commented on pull request #19731: fix(chart explorer): Chart does not cover the entire page with Standalone=1 #15252
Posted by GitBox <gi...@apache.org>.
nraschi commented on PR #19731:
URL: https://github.com/apache/superset/pull/19731#issuecomment-1103776125
>
Hi @villebro, I'm trying to rebase, but unfortunately, I didn't create a branch on my fork and now I can't fetch the upstream to fix that conflict.
Is there a way to resolve this? Like a new fork will maintain this PR?
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org