[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38331: [SPARK-40869][K8S] Resource name prefix should not start with a -

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38331:
URL: https://github.com/apache/spark/pull/38331#discussion_r1013200861


##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala:
##########
@@ -250,4 +250,8 @@ class KubernetesConfSuite extends SparkFunSuite {
     assert(KubernetesConf.getAppNameLabel("a" * 62 + "-aaa") === "a" * 62)
     assert(KubernetesConf.getAppNameLabel("-" + "a" * 63) === "a" * 62)
   }
+
+  test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid name prefixes") {

Review Comment:
   The test case title is too broad. Shall we match it with the title?
   ```scala
   - test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid name prefixes") {
   + test("SPARK-40869: getResourceNamePrefix should remove leading hypens") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org