You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/05/04 16:30:02 UTC

[GitHub] [ratis] softgitron commented on pull request #468: RATIS-1364 Fix Sonar Qube issues in IOUtils

softgitron commented on pull request #468:
URL: https://github.com/apache/ratis/pull/468#issuecomment-832076689


   > @softgitron , thanks for working on this!
   > 
   > Please fix the NPE bugs but not changing code style (e.g. for-loop to while-loop). We should avoid unnecessary changes such as code style changes or whitespace changes. Some people may find for-loop better and some others may like while-loop more.
   
   Understood! I see, these random fixes have become a bad habit for me. In some of my previous projects these kind of small fixes were endorsed by maintainers and because of that I still slip those in the PR. In this case fixes were made based on the SonarQube recommendations.
   
   I try to avoid this behavior with this project from now on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org