You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/09/24 19:13:01 UTC

[GitHub] [daffodil] dependabot[bot] opened a new pull request #644: Bump actions/github-script from 4.1 to 5

dependabot[bot] opened a new pull request #644:
URL: https://github.com/apache/daffodil/pull/644


   Bumps [actions/github-script](https://github.com/actions/github-script) from 4.1 to 5.
   <details>
   <summary>Release notes</summary>
   <p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p>
   <blockquote>
   <h2>v5.0.0</h2>
   <h2>What's Changed</h2>
   <ul>
   <li>Upgrade to the latest version of Octokit by <a href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a href="https://github-redirect.dependabot.com/actions/github-script/pull/193">actions/github-script#193</a></li>
   </ul>
   <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v4.1.1...v5.0.0">https://github.com/actions/github-script/compare/v4.1.1...v5.0.0</a></p>
   <h2>v4.1.1</h2>
   <h2>What's Changed</h2>
   <ul>
   <li>Update minor versions of dependencies by <a href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a href="https://github-redirect.dependabot.com/actions/github-script/pull/192">actions/github-script#192</a></li>
   </ul>
   <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v4.1.0...v4.1.1">https://github.com/actions/github-script/compare/v4.1.0...v4.1.1</a></p>
   </blockquote>
   </details>
   <details>
   <summary>Commits</summary>
   <ul>
   <li><a href="https://github.com/actions/github-script/commit/441359b1a30438de65712c2fbca0abe4816fa667"><code>441359b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/github-script/issues/193">#193</a> from actions/joshmgross/v5</li>
   <li><a href="https://github.com/actions/github-script/commit/4e1175c48335078132afc3f5dc1b7e27219c659a"><code>4e1175c</code></a> Update licenses</li>
   <li><a href="https://github.com/actions/github-script/commit/004e46f649b61c0e1d436150ee9868171180fbe8"><code>004e46f</code></a> Fix breaking change in workflow test</li>
   <li><a href="https://github.com/actions/github-script/commit/5e5d515dc7088569e3d5a2cfecfe542588a1efc6"><code>5e5d515</code></a> Upgrade to the latest version of Octokit</li>
   <li>See full diff in <a href="https://github.com/actions/github-script/compare/v4.1...v5">compare view</a></li>
   </ul>
   </details>
   <br />
   
   
   [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/github-script&package-manager=github_actions&previous-version=4.1&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   <details>
   <summary>Dependabot commands and options</summary>
   <br />
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
   
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji commented on pull request #644: Bump actions/github-script from 4.1 to 5

Posted by GitBox <gi...@apache.org>.
tuxji commented on pull request #644:
URL: https://github.com/apache/daffodil/pull/644#issuecomment-926903827


   The github script indeed broke after updating this action to v5.  Here's the explanation.
   
   ## Breaking changes in V5
   
   Version 5 of this action includes the version 5 of `@actions/github` and `@octokit/plugin-rest-endpoint-methods`. As part of this update, the Octokit context available via `github` no longer has REST methods directly. These methods are available via `github.rest.*` - https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/tag/v5.0.0
   
   For example, `github.issues.createComment` in V4 becomes `github.rest.issues.createComment` in V5
   
   `github.request`, `github.paginate`, and `github.graphql` are unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #644: Bump actions/github-script from 4.1 to 5

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #644:
URL: https://github.com/apache/daffodil/pull/644#issuecomment-927833536


   +1
      
    - [X] **Do all automated continuous integration checks pass?**
    Yes, with the `github.rest...` fixed. Confirmed that this correctly passes if there is a single commit and errors if there are multiple.
   - [X] **Is the update a patch, minor, or major update?**
   Major update, but changes updates dependencies
    - [X] **Is the license still compatible with ASF License Policy?**
    Yes, still MIT.
    - [X] **Have any changes been made to LICENSE/NOTICE files that need to be incorporated?**
    No changes, but not applicable, we don't distribute
    - [X] **Have any transitive dependencies been added or changed?**
    Not applicable, we don't distribute


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence merged pull request #644: Bump actions/github-script from 4.1 to 5

Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #644:
URL: https://github.com/apache/daffodil/pull/644


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] stevedlawrence commented on pull request #644: Bump actions/github-script from 4.1 to 5

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #644:
URL: https://github.com/apache/daffodil/pull/644#issuecomment-927852015


   Good call, updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [daffodil] tuxji commented on pull request #644: Bump actions/github-script from 4.1 to 5

Posted by GitBox <gi...@apache.org>.
tuxji commented on pull request #644:
URL: https://github.com/apache/daffodil/pull/644#issuecomment-927849538


   Please bump github-script to v5.0.0, not v5.  The v5.x.x tags are immutable,  but the v5 tag will change in the future to stay synchronized to the latest v5.x.x tag, which will bypass dependabot's alerts prompting us to check each v5.x.x update carefully.  I consider this a bug in dependabot itself (it should be smart enough to know the difference between an immutable tag and a mutable tag and not bump from an immutable tag to a mutable tag).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org