You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/08/23 20:14:57 UTC

[GitHub] [logging-log4j2] carterkozak commented on pull request #567: LOG4J2-3142: Use log event time millis for timestamp in log event adapter

carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904089216


   Looks reasonable to me. Any chance you can provide a minimal test case? Something as simple as an additional assert in `RewriteAppenderTest` should do the trick, we can verify the value is greater than or equal to the system time when the test starts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org