[GitHub] [solr] markrmiller commented on pull request #194: SOLR-15475: Implement COUNT and APPROX_COUNT_DISTINCT aggregation functions for Parallel SQL

[GitBox <gi...@apache.org>]

markrmiller commented on pull request #194:
URL: https://github.com/apache/solr/pull/194#issuecomment-870732569


   Looks okay to me other than the todo to uncomment. In a other issue I have some work / ideas around taking advantage of the approx count in a caching somewhat lazy way to so we can try and cheaply use use a distinct approx that doesn't always have to be super accurate or up to date to influence the planner or our own decisions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org