You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Bob Dionne (JIRA)" <ji...@apache.org> on 2012/10/11 13:09:02 UTC

[jira] [Commented] (COUCHDB-1557) upgrade some code to use BIFs

    [ https://issues.apache.org/jira/browse/COUCHDB-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474038#comment-13474038 ] 

Bob Dionne commented on COUCHDB-1557:
-------------------------------------

I've also made similar changes to ibrowse[1], for which I can submit a patch once it's been decided how upstream projects will be handled in the new build

[1] https://github.com/cloudant/ibrowse/commit/cc1f8e84a669b37
                
> upgrade some code to use BIFs
> -----------------------------
>
>                 Key: COUCHDB-1557
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1557
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface, Replication
>            Reporter: Bob Dionne
>            Priority: Minor
>         Attachments: 0001-Upgrade-code-to-use-BIFs-for-improved-performance.patch
>
>
> couch_httpd:find_in_binary can now make  use of the binary module introduced in R14 -- eprof runs of the replication can show good improvements with this patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (COUCHDB-1557) upgrade some code to use BIFs

Posted by Bob Dionne <di...@dionne-associates.com>.
Hi Benoitc,

I haven't seem hackney yet, I'd have to try it out. I've been doing some profiling on the replicator and noticed a lot of time spent in ibrowse functions, which is what you'd expect I guess. So I'd have to see a major performance boost to be a believer. I'll try it when I find some time.

Cheers,

Bob

On Oct 24, 2012, at 7:05 AM, Benoit Chesneau <bc...@gmail.com> wrote:

> On Thu, Oct 11, 2012 at 1:09 PM, Bob Dionne (JIRA) <ji...@apache.org> wrote:
>> 
>>    [ https://issues.apache.org/jira/browse/COUCHDB-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474038#comment-13474038 ]
>> 
>> Bob Dionne commented on COUCHDB-1557:
>> -------------------------------------
>> 
>> I've also made similar changes to ibrowse[1], for which I can submit a patch once it's been decided how upstream projects will be handled in the new build
>> 
>> [1] https://github.com/cloudant/ibrowse/commit/cc1f8e84a669b37
>> 
> 
> I was thinking to replace ibrowse by hackney
> (http://github.com/benoitc/hackney) . It is fullly binary and
> streamed. What do you think about it ?
> 
> 
>>> upgrade some code to use BIFs
>>> -----------------------------
>>> 
>>>                Key: COUCHDB-1557
>>>                URL: https://issues.apache.org/jira/browse/COUCHDB-1557
>>>            Project: CouchDB
>>>         Issue Type: Improvement
>>>         Components: HTTP Interface, Replication
>>>           Reporter: Bob Dionne
>>>           Priority: Minor
>>>        Attachments: 0001-Upgrade-code-to-use-BIFs-for-improved-performance.patch
>>> 
>>> 
>>> couch_httpd:find_in_binary can now make  use of the binary module introduced in R14 -- eprof runs of the replication can show good improvements with this patch
>> 
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: [jira] [Commented] (COUCHDB-1557) upgrade some code to use BIFs

Posted by Robert Newson <rn...@apache.org>.
Too late for 1.3, imo. Nothing stopping you making a branch of master
with hackney instead of ibrowse, though, could be fun.

On 24 October 2012 12:05, Benoit Chesneau <bc...@gmail.com> wrote:
> On Thu, Oct 11, 2012 at 1:09 PM, Bob Dionne (JIRA) <ji...@apache.org> wrote:
>>
>>     [ https://issues.apache.org/jira/browse/COUCHDB-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474038#comment-13474038 ]
>>
>> Bob Dionne commented on COUCHDB-1557:
>> -------------------------------------
>>
>> I've also made similar changes to ibrowse[1], for which I can submit a patch once it's been decided how upstream projects will be handled in the new build
>>
>> [1] https://github.com/cloudant/ibrowse/commit/cc1f8e84a669b37
>>
>
> I was thinking to replace ibrowse by hackney
> (http://github.com/benoitc/hackney) . It is fullly binary and
> streamed. What do you think about it ?
>
>
>>> upgrade some code to use BIFs
>>> -----------------------------
>>>
>>>                 Key: COUCHDB-1557
>>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1557
>>>             Project: CouchDB
>>>          Issue Type: Improvement
>>>          Components: HTTP Interface, Replication
>>>            Reporter: Bob Dionne
>>>            Priority: Minor
>>>         Attachments: 0001-Upgrade-code-to-use-BIFs-for-improved-performance.patch
>>>
>>>
>>> couch_httpd:find_in_binary can now make  use of the binary module introduced in R14 -- eprof runs of the replication can show good improvements with this patch
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (COUCHDB-1557) upgrade some code to use BIFs

Posted by Benoit Chesneau <bc...@gmail.com>.
On Thu, Oct 11, 2012 at 1:09 PM, Bob Dionne (JIRA) <ji...@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/COUCHDB-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474038#comment-13474038 ]
>
> Bob Dionne commented on COUCHDB-1557:
> -------------------------------------
>
> I've also made similar changes to ibrowse[1], for which I can submit a patch once it's been decided how upstream projects will be handled in the new build
>
> [1] https://github.com/cloudant/ibrowse/commit/cc1f8e84a669b37
>

I was thinking to replace ibrowse by hackney
(http://github.com/benoitc/hackney) . It is fullly binary and
streamed. What do you think about it ?


>> upgrade some code to use BIFs
>> -----------------------------
>>
>>                 Key: COUCHDB-1557
>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1557
>>             Project: CouchDB
>>          Issue Type: Improvement
>>          Components: HTTP Interface, Replication
>>            Reporter: Bob Dionne
>>            Priority: Minor
>>         Attachments: 0001-Upgrade-code-to-use-BIFs-for-improved-performance.patch
>>
>>
>> couch_httpd:find_in_binary can now make  use of the binary module introduced in R14 -- eprof runs of the replication can show good improvements with this patch
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira