You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/06 17:50:30 UTC
[GitHub] [cordova-plugin-network-information] breautek opened a new pull request #116: WIP: Doc cleanup
breautek opened a new pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
none (docs update)
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Removes obsolete documentation that no longer applies for variety of reasons.
### Description
<!-- Describe your changes in detail -->
- Removed Apache Jira link because we use github for issue tracking now.
- Removed iOS 7 quirk because it is an unsupported platform
- TODO: Planning on rewriting the file transfer example because the file transfer plugin is deprecated.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] PieterVanPoyer edited a comment on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer edited a comment on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640708220
> Basically wondering if it should be added as a general note or an "iOS Quirk".
Can be added as a general note (for ios and android).
In Android the javascript might execute, but the native broadcastreceiver is unregistered : https://github.com/apache/cordova-plugin-network-information/blob/9f8527062776ead04982d7fab12875a66bf69855/src/android/NetworkManager.java#L140-L143
So no change from network is detected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] breautek closed pull request #116: docs: Doc cleanup
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] breautek closed pull request #116: docs: Doc cleanup
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] breautek commented on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640941201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] PieterVanPoyer commented on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640189634
In the issues, from time to time there are questions about events in the background.
If I read the code, I think that ios stops dispatching events when the app is in the background.
This is also true for the android setup.
https://github.com/apache/cordova-plugin-network-information/blob/9f8527062776ead04982d7fab12875a66bf69855/src/ios/CDVConnection.m#L135-L144
Maybe this should be mentioned in the Docs? It should solve/clarify issues like: https://github.com/apache/cordova-plugin-network-information/issues/102
Kind regards
Pieter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] PieterVanPoyer commented on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640708220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] breautek commented on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640233133
@PieterVanPoyer Do you know if this only applies to the iOS platform? I know Android does allow javascript execution in the background unlike iOS, although execution is throttled.
Basically wondering if it should be added as a general note or an "iOS Quirk".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-network-information] breautek edited a comment on pull request #116: WIP: Doc cleanup
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #116:
URL: https://github.com/apache/cordova-plugin-network-information/pull/116#issuecomment-640233133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org