[jira] [Commented] (GEODE-3019) Refactor Struct

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077206#comment-16077206 ] 

ASF GitHub Bot commented on GEODE-3019:
---------------------------------------

GitHub user echobravopapa opened a pull request:

    https://github.com/apache/geode-native/pull/107

    GEODE-3019: Refactor Struct class

    - Using std::string now
    
    - this also addresses GEODE-3020, the map now used standard types

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-3019

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit a502ce378d26ce374b51c4198f93bbf7d70116a6
Author: Ernest Burghardt <eb...@pivotal.io>
Date:   2017-06-30T21:42:01Z

    GEODE-3019: Refactor Struct class
    
    - Using std::string now

----


> Refactor Struct
> ---------------
>
>                 Key: GEODE-3019
>                 URL: https://issues.apache.org/jira/browse/GEODE-3019
>             Project: Geode
>          Issue Type: Task
>          Components: native client
>            Reporter: Jacob S. Barrett
>
> Refactor Struct (geode/Struct.hpp):
> * Replace {{char *}} with {{std::string}}
> * Replace {{m_fieldname}} type with {{std::unordered_map<std::string, int32_t>}}
> * Add vector for index to field name lookup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)