You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "John Kaputin (JIRA)" <ji...@apache.org> on 2008/01/29 18:30:35 UTC

[jira] Created: (WODEN-195) Improve formatting of messages with no message parameters

Improve formatting of messages with no message parameters
---------------------------------------------------------

                 Key: WODEN-195
                 URL: https://issues.apache.org/jira/browse/WODEN-195
             Project: Woden
          Issue Type: Improvement
            Reporter: John Kaputin
            Assignee: John Kaputin
             Fix For: M8
         Attachments: woden195.patch

Minor improvement to how formatted messages are handled by Woden when there are no message parameters involved. 
1. Permit the ErrorReporter.getFormattedMessage API method to accept null instead of an empty Object array
2. Eliminate unnecessary use of local variables in calls to ErrorReporter
3. Define a static empty Object array in MessageFormatter to pass to MessageFormat instead of a null value when no message parms are used (seems to work OK with a null value, but the java.text.MessageFormat javadoc does not explicitly permit nulls, so am adding this step to avoid possible JRE implementation differences in future).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Closed: (WODEN-195) Improve formatting of messages with no message parameters

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin closed WODEN-195.
------------------------------


> Improve formatting of messages with no message parameters
> ---------------------------------------------------------
>
>                 Key: WODEN-195
>                 URL: https://issues.apache.org/jira/browse/WODEN-195
>             Project: Woden
>          Issue Type: Improvement
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>         Attachments: woden195.patch
>
>
> Minor improvement to how formatted messages are handled by Woden when there are no message parameters involved. 
> 1. Permit the ErrorReporter.getFormattedMessage API method to accept null instead of an empty Object array
> 2. Eliminate unnecessary use of local variables in calls to ErrorReporter
> 3. Define a static empty Object array in MessageFormatter to pass to MessageFormat instead of a null value when no message parms are used (seems to work OK with a null value, but the java.text.MessageFormat javadoc does not explicitly permit nulls, so am adding this step to avoid possible JRE implementation differences in future).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-195) Improve formatting of messages with no message parameters

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WODEN-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563585#action_12563585 ] 

John Kaputin commented on WODEN-195:
------------------------------------

r616457
Applied patch.

> Improve formatting of messages with no message parameters
> ---------------------------------------------------------
>
>                 Key: WODEN-195
>                 URL: https://issues.apache.org/jira/browse/WODEN-195
>             Project: Woden
>          Issue Type: Improvement
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>         Attachments: woden195.patch
>
>
> Minor improvement to how formatted messages are handled by Woden when there are no message parameters involved. 
> 1. Permit the ErrorReporter.getFormattedMessage API method to accept null instead of an empty Object array
> 2. Eliminate unnecessary use of local variables in calls to ErrorReporter
> 3. Define a static empty Object array in MessageFormatter to pass to MessageFormat instead of a null value when no message parms are used (seems to work OK with a null value, but the java.text.MessageFormat javadoc does not explicitly permit nulls, so am adding this step to avoid possible JRE implementation differences in future).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Updated: (WODEN-195) Improve formatting of messages with no message parameters

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin updated WODEN-195:
-------------------------------

    Attachment: woden195.patch

Adding woden195.patch.txt

> Improve formatting of messages with no message parameters
> ---------------------------------------------------------
>
>                 Key: WODEN-195
>                 URL: https://issues.apache.org/jira/browse/WODEN-195
>             Project: Woden
>          Issue Type: Improvement
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>         Attachments: woden195.patch
>
>
> Minor improvement to how formatted messages are handled by Woden when there are no message parameters involved. 
> 1. Permit the ErrorReporter.getFormattedMessage API method to accept null instead of an empty Object array
> 2. Eliminate unnecessary use of local variables in calls to ErrorReporter
> 3. Define a static empty Object array in MessageFormatter to pass to MessageFormat instead of a null value when no message parms are used (seems to work OK with a null value, but the java.text.MessageFormat javadoc does not explicitly permit nulls, so am adding this step to avoid possible JRE implementation differences in future).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Resolved: (WODEN-195) Improve formatting of messages with no message parameters

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WODEN-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Kaputin resolved WODEN-195.
--------------------------------

    Resolution: Fixed

Fixed.

> Improve formatting of messages with no message parameters
> ---------------------------------------------------------
>
>                 Key: WODEN-195
>                 URL: https://issues.apache.org/jira/browse/WODEN-195
>             Project: Woden
>          Issue Type: Improvement
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>         Attachments: woden195.patch
>
>
> Minor improvement to how formatted messages are handled by Woden when there are no message parameters involved. 
> 1. Permit the ErrorReporter.getFormattedMessage API method to accept null instead of an empty Object array
> 2. Eliminate unnecessary use of local variables in calls to ErrorReporter
> 3. Define a static empty Object array in MessageFormatter to pass to MessageFormat instead of a null value when no message parms are used (seems to work OK with a null value, but the java.text.MessageFormat javadoc does not explicitly permit nulls, so am adding this step to avoid possible JRE implementation differences in future).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org