You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/25 16:47:37 UTC

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18921: Einsum cutensor GPU

sxjscience commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r495110765



##########
File path: 3rdparty/mshadow/mshadow/stream_gpu-inl.h
##########
@@ -196,10 +206,75 @@ struct Stream<gpu> {
     CHECK_EQ(err, CUDNN_STATUS_SUCCESS) << cudnnGetErrorString(err);
 #endif
   }
+#if MSHADOW_USE_CUTENSOR == 1
+  inline static cutensorHandle_t GetCuTensorHandle(Stream<gpu> *stream) {
+    //if (stream == NULL) {
+    //  return 0;
+    //} else {

Review comment:
       Should we check that *stream cannot be NULL?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org