You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/01 10:48:09 UTC
[GitHub] [apisix] soulbird opened a new pull request #6780: fix: the purge method cannot be configured in routes
soulbird opened a new pull request #6780:
URL: https://github.com/apache/apisix/pull/6780
### Description
Allows adding purge method restrictions to routes.
The purge method is used in the proxy-cache plugin and is usually used to flush the cache.
Fixes #6766
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis removed a comment on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
membphis removed a comment on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086598302
> need to add a new test case:
>
> 1. set route with `PURGE` method
> 2. hit the route by http request (PURGE method)
> 3. check the response context
@soulbird What is your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086598302
> need to add a new test case:
>
> 1. set route with `PURGE` method
> 2. hit the route by http request (PURGE method)
> 3. check the response context
@soulbird What is your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086566503
https://github.com/apache/apisix/blob/97bcb565075e59372842973844216c129af5d812/apisix/plugins/proxy-rewrite.lua#L27-L34
https://github.com/apache/apisix/blob/97bcb565075e59372842973844216c129af5d812/apisix/plugins/proxy-rewrite.lua#L50-L54
The `proxy-rewrite` plugin support method rewrite also, should we modify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086598736
> https://github.com/api7/lua-resty-radixtree/blob/master/t/sanity.t#L347
You need to use real test cases, we may find bug in real test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
soulbird commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086599707
> > need to add a new test case:
> >
> > 1. set route with `PURGE` method
> > 2. hit the route by http request (PURGE method)
> > 3. check the response context
>
> Route matching has added test case here https://github.com/api7/lua-resty-radixtree/blob/master/t/sanity.t#L347
> > https://github.com/api7/lua-resty-radixtree/blob/master/t/sanity.t#L347
>
> You need to use real test cases, we may find bug in real test case.
> > https://github.com/api7/lua-resty-radixtree/blob/master/t/sanity.t#L347
>
> You need to use real test cases, we may find bug in real test case.
OK, I will add test cases related route matching. And the test cases related resppnse context has already added in proxy-cache plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #6780: fix: the purge method cannot be configured in routes
Posted by GitBox <gi...@apache.org>.
soulbird commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086445369
> need to add a new test case:
>
> 1. set route with `PURGE` method
> 2. hit the route by http request (PURGE method)
> 3. check the response context
Route matching has added test case here https://github.com/api7/lua-resty-radixtree/blob/master/t/sanity.t#L347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #6780: fix: allow the purge method to purge cache
Posted by GitBox <gi...@apache.org>.
soulbird commented on pull request #6780:
URL: https://github.com/apache/apisix/pull/6780#issuecomment-1086589137
> https://github.com/apache/apisix/blob/97bcb565075e59372842973844216c129af5d812/apisix/plugins/proxy-rewrite.lua#L27-L34
>
> https://github.com/apache/apisix/blob/97bcb565075e59372842973844216c129af5d812/apisix/plugins/proxy-rewrite.lua#L50-L54
>
> The `proxy-rewrite` plugin support method rewrite also, should we modify it?
We support the `PURGE` method for the proxy-cache plugin. But `PURGE` is not a standard method, we don't need to support proxy `PURGE` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org