You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by fi...@apache.org on 2017/02/10 23:25:16 UTC
cordova-coho git commit: check that gpg is on the path before kicking
the release process off.
Repository: cordova-coho
Updated Branches:
refs/heads/plugins-releaser 5dfb3c783 -> 49b8f725d
check that gpg is on the path before kicking the release process off.
Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/49b8f725
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/49b8f725
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/49b8f725
Branch: refs/heads/plugins-releaser
Commit: 49b8f725d39f0d09f550c3103c0b54e806a5bc38
Parents: 5dfb3c7
Author: filmaj <ma...@gmail.com>
Authored: Fri Feb 10 15:23:03 2017 -0800
Committer: filmaj <ma...@gmail.com>
Committed: Fri Feb 10 15:23:03 2017 -0800
----------------------------------------------------------------------
src/create-verify-archive.js | 2 ++
src/plugin-release.js | 11 ++++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/49b8f725/src/create-verify-archive.js
----------------------------------------------------------------------
diff --git a/src/create-verify-archive.js b/src/create-verify-archive.js
index e761690..988a446 100644
--- a/src/create-verify-archive.js
+++ b/src/create-verify-archive.js
@@ -33,6 +33,8 @@ var print = apputil.print;
var settingUpGpg = path.resolve(path.dirname(__dirname), 'docs', 'setting-up-gpg.md');
var isWin = process.platform === 'win32';
+exports.GPG_DOCS = settingUpGpg;
+
exports.createCommand = function*(argv) {
var opt = flagutil.registerRepoFlag(optimist)
opt = opt
http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/49b8f725/src/plugin-release.js
----------------------------------------------------------------------
diff --git a/src/plugin-release.js b/src/plugin-release.js
index 0559595..83fdd1d 100644
--- a/src/plugin-release.js
+++ b/src/plugin-release.js
@@ -63,7 +63,13 @@ var plugins_ommitted = []; // array of plugin names that DO NOT need releasing
function *interactive_plugins_release() {
console.log('Hi! So you want to do a plugins release, do you?');
- // TODO: run a shelljs.which(gpg) to make sure RM has gpg on their path
+ // run a shelljs.which(gpg) to make sure RM has gpg on their path
+ console.log("You'll need gpg installed and have your Apache GPG keys all set up. Let me check if you have that locally...");
+ if (!shelljs.which('gpg')) {
+ console.error('Did not find gpg on your PATH!');
+ console.error('Refer to ' + create_archive.GPG_DOCS + ' for instructions on how to get that set up as a first step.');
+ process.exit(1);
+ }
console.log('Let\'s start with your JIRA credentials - this system will be interacting with Apache\'s JIRA instance (issues.apache.org) often.');
inquirer.prompt([{
type: 'input',
@@ -128,8 +134,7 @@ function *interactive_plugins_release() {
});
} else {
console.error('You should get your GPG keys sorted out first!');
- console.warn('Follow the instructions here, then come back and try again :)');
- console.warn('https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md');
+ console.warn('Follow the instructions here, then come back and try again: ' + create_archive.GPG_DOCS);
process.exit(2);
}
}).then(function(answer) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org