[GitHub] [kafka] jeqo commented on a diff in pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

["jeqo (via GitHub)" <gi...@apache.org>]

jeqo commented on code in PR #14045:
URL: https://github.com/apache/kafka/pull/14045#discussion_r1269038188


##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##########
@@ -182,13 +182,12 @@ private CompletableFuture<Void> storeRemoteLogMetadata(TopicIdPartition topicIdP
             CompletableFuture<RecordMetadata> produceFuture = producerManager.publishMessage(remoteLogMetadata);
 
             // Create and return a `CompletableFuture` instance which completes when the consumer is caught up with the produced record's offset.
-            return produceFuture.thenApplyAsync(recordMetadata -> {
+            return produceFuture.thenAcceptAsync(recordMetadata -> {
                 try {
-                    consumerManager.waitTillConsumptionCatchesUp(recordMetadata);
+                    consumerManager.waitTillConsumptionCatchesUp(recordMetadata.partition(), recordMetadata.offset());

Review Comment:
   Of course, missed this one -- pushed fixes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org